504874 - [10.4] Match 10.4 menu highlighting in location bar autocomplete

Status: RESOLVED FIXED

(Camino Graveyard :: Location Bar & Autocomplete, defect)

Description

[Stuart Morgan]

It would be nice if we used 10.4 menu highlighting style on 10.4. Can someone with 10.4 access grab a screenshot of a highlighted menu and post it here for color extraction?

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Graphite, too.

There really aren't constants for these?

Comment 2

[Christopher Henderson]

Attachment: 10.4 menu highlighting, aqua

Comment 3

[Christopher Henderson]

Attachment: 10.4 menu highlighting, graphite

Comment 4

[Eiichi]

Attachment: 10.4 Screenshot

Comment 5

[Eiichi]

Attachment: DigitalColor Meter Screenshot

Aqua:
[NSColor colorWithDeviceRed:0.000000 green:0.392157 blue:0.901961 alpha:1.0]

Graphite:
[NSColor colorWithDeviceRed:0.392157 green:0.474510 blue:0.568627 alpha:1.0]

Comment 6

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

This seems like something we should fix for 2.1.

Comment 7

[Dan Weber]

Attachment: Patch 1

Comment 8

[Stuart Morgan]

Comment on attachment 423264 [details] [diff] [review]
Patch 1

>+    NSRectFill(NSMakeRect(rect.origin.x, rect.origin.y - 1, rect.size.width, 1));
>+    [bottomColor set];
>+    NSRectFill(NSMakeRect(rect.origin.x, rect.origin.y - 1 + rect.size.height + 1, rect.size.width, 1));

It might make sense to reduce the duplication here by making the first rect outside the fill call, and then just changing its y origin and re-using it in the second fill, since everything else is the same.

Not a big deal though (especially since it's not new code); r=me either way.

Comment 9

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 423264 [details] [diff] [review]
Patch 1

sr=pink

Comment 10

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Dan, are you going to make the change Stuart mentioned in comment 8, or should I just check this in as-is?

Comment 11

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Landed on cvs trunk as-is, but filed bug 547495 on comment 8.