Closed Bug 504972 Opened 15 years ago Closed 15 years ago

[FIX]Remove some redundant framelist code

Categories

(Core :: Layout, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

Attachments

(1 file, 2 obsolete files)

Attached patch Proposed fix (obsolete) — Splinter Review
All the various InsertFrame(s) and AppendFrame(s) signatures can just call directly through to one InsertFrames implementation, after asserting some things about their arguments.  No point having lots of similar code around that will be error-prone to change as we change the underlying implementation.
Attachment #389253 - Flags: superreview?(roc)
Attachment #389253 - Flags: review?(roc)
Attached patch With the comments fixed (obsolete) — Splinter Review
Attachment #389253 - Attachment is obsolete: true
Attachment #389254 - Flags: superreview?(roc)
Attachment #389254 - Flags: review?(roc)
Attachment #389253 - Flags: superreview?(roc)
Attachment #389253 - Flags: review?(roc)
Attachment #389254 - Flags: superreview?(roc)
Attachment #389254 - Flags: superreview+
Attachment #389254 - Flags: review?(roc)
Attachment #389254 - Flags: review+
Attachment #389254 - Attachment is obsolete: true
Pushed http://hg.mozilla.org/mozilla-central/rev/789ad87b7440
Status: NEW → RESOLVED
Closed: 15 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: