If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

[FIX]Remove some redundant framelist code

RESOLVED FIXED

Status

()

Core
Layout
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: bz, Assigned: bz)

Tracking

Trunk
x86
Mac OS X
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

Created attachment 389253 [details] [diff] [review]
Proposed fix

All the various InsertFrame(s) and AppendFrame(s) signatures can just call directly through to one InsertFrames implementation, after asserting some things about their arguments.  No point having lots of similar code around that will be error-prone to change as we change the underlying implementation.
Attachment #389253 - Flags: superreview?(roc)
Attachment #389253 - Flags: review?(roc)
Created attachment 389254 [details] [diff] [review]
With the comments fixed
Attachment #389253 - Attachment is obsolete: true
Attachment #389254 - Flags: superreview?(roc)
Attachment #389254 - Flags: review?(roc)
Attachment #389253 - Flags: superreview?(roc)
Attachment #389253 - Flags: review?(roc)
Attachment #389254 - Flags: superreview?(roc)
Attachment #389254 - Flags: superreview+
Attachment #389254 - Flags: review?(roc)
Attachment #389254 - Flags: review+
Created attachment 389616 [details] [diff] [review]
Merged to updated patches for bug 504221
Attachment #389254 - Attachment is obsolete: true
Pushed http://hg.mozilla.org/mozilla-central/rev/789ad87b7440
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.