505089 - about:config highlight override does not work

Status: RESOLVED INCOMPLETE

(Firefox :: General, defect)

Description

[jdegroof]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1.1) Gecko/20090715 Firefox/3.5.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1.1) Gecko/20090715 Firefox/3.5.1

After researching how to get rid of the new god-awful pink highlight all color, I found the following two about:config strings.  Problem is, when set yellow/black, reversing the color setting always results in yellow text with black background.

ui.textHighlightForeground #000000
ui.textHighlightBackground #FFFF00


Reproducible: Always

Steps to Reproduce:
1. Add two strings above
2. Select "highlight all"
3.
Actual Results:  
Always black background with yellow text with those settings (reversing does not change anything).

Expected Results:  
Expected the great old yellow highlight with black text.

All else default - never used about:config before.

Comment 1

[Maxwell J. Koo]

Attachment: Proposed patch

Bug confirmed in latest hg checkout of firefox, it seems that when the UI calculates the minimum threshold for contrast, it takes into account the selection highlight color but not the search highlight color. This patch addresses this issue without removing the call to EnsureSufficientContrast in GetHighlightColors in nsTextFrameThebes.cpp. It is important this behavior is still in place, for instance, if we are searching a page who's background color is #FFFF00.

Comment 2

[Maxwell J. Koo]

Attachment: Test page for patch

Contrived example to show the differences in highlighting behavior given different color backgrounds. Here is a screenshot of the current behavior (which I believe is incorrect): http://imgur.com/WrfpQ.png . The corrected behavior: http://imgur.com/TQnff.png . Loaded page without highlighting: http://imgur.com/ilFRs.png .

Comment 3

[Tyler Downer [He/Him]]

Reporter, are you still seeing this issue with Firefox 4.0.1 or later in safe mode or a fresh profile? If not, please close. These links can help you in your testing.
http://support.mozilla.com/kb/Safe+Mode
http://support.mozilla.com/kb/Managing+profiles

Comment 4

[Nick Knowlson]

I'm not the original reporter, but I was seeing this issue before as well. 

I have Firefox 4.0.1 and restarted it in safe mode to check, but the highlighting behavior remains unchanged.

Comment 5

[Tyler Downer [He/Him]]

No reply, INCOMPLETE. Please retest with Firefox 4 or later and a new profile (http://support.mozilla.com/kb/Managing+profiles). Also, ensure you have the most up to date graphics drivers, operating system updates, and plugin versions (flash, java, etc). If you continue to see this issue with the newest Firefox and a new profile, then please comment on this bug.

Comment 6

[Justin Dolske [:Dolske]]

Comment on attachment 491624 [details] [diff] [review]
Proposed patch

Clearing review request on "incomplete" bug. If this is still an issue with current versions of firefox, please update the patch and assign to a specific review (such as me!).