505228 - JSON.stringify generates non standard output if "space" is defined

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Fabian Jakobs]

User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; de; rv:1.9.1.1) Gecko/20090715 Firefox/3.5.1

If the "space" argument of the JSON.stringify method is given, arrays are not correctly
stringified as expected by the EcmaScript 3.1 specification. Firefox does not insert
a new line character after the opening bracket:

Current behavior:

alert(JSON.stringify(['e'], null, '\t'))

["e"
]


expected: 

[
	"e"
]


Quote from the spec:

9. If partial is empty ,then 
  a. Let final be "[]". 

10. Else 
  a. If gap is the empty string 
    i. Let properties be a string formed by concatenating all the element strings of partial  
       with each adjacent pair of strings separated with the comma character. A comma is 
       not inserted either before the first string or after the last string.  
    ii. Let final be the result of concatenating "[", properties, and "]". 

  b. Else 
    i. Let separator be the result of concatenating  the comma character, the line feed 
       character, and indent. 
    ii. Let properties be a string formed by concatenating all the element strings of partial  
        with each adjacent pair of strings separated with separator. The separator string is 
        not inserted either before the first string or after the last string. 
    iii. Let final be the result of concatenating "[", the line feed character, indent, 
         properties, the line feed character, stepback, and "]".

Comment 1

[Michael Ryan]

Attachment: testcase from comment #0

Comment 2

[Michael Ryan]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a1pre) Gecko/20090823 Minefield/3.7a1pre

Confirmed.

Comment 3

[Saint Wesonga]

Attachment: Patch v1

Comment 4

[Robert Sayre]

good patch. it needs a test, though.

Comment 5

[Saint Wesonga]

Attachment: Patch

Comment 6

[Saint Wesonga]

Attachment: Patch

Applies cleanly.

Comment 7

[Robert Sayre]

http://hg.mozilla.org/tracemonkey/rev/469f9b414b4e

Comment 8

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/469f9b414b4e