50553 - PERF: placeholder txn's keeping selection state info around for too long

Status: RESOLVED INCOMPLETE

(Core :: DOM: Editor, defect, P5)

Description

[Joe Francis]

Whenever you type, that transaction is merged into the previous one (if it was 
also typing).  But the selection state info saved with each transaction is not 
coellesced here, resulting in a lot of tiny mallocs adding up as you type.  I 
should touch this up so that only the "outmost" txn saves selection info, and 
also so that the selection state memory usage is taken from a recycleable pool.

Comment 1

[rubydoo123]

moving to m19

Comment 2

[Joe Francis]

you will be mine you will be mine all mine... (coming to this bug's emotional 
rescue)

Comment 3

[rubydoo123]

marking future, setting to nsbeta3- per review by bijal and beppe

Comment 4

[Jens Stutte [:jstutte]]

Bulk-downgrade of unassigned, >=5 years untouched DOM/Storage bugs' priority.

If you have reason to believe this is wrong (especially for the severity), please write a comment and ni :jstutte.

Comment 5

[Henri Sivonen (:hsivonen)]

Masayuki, does this still look relevant, or should we close this?

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Although I'm not familiar with merging multiple transactions, looks like that about PlaceholderTransaction, the older one is kept and the new one is discarded after the merge. Therefore, PlaceholderTransaction::mStartSel and PlaceholderTransaction::mEndSel is stored only required ones now.