50554 - Need to remove treechildren BEFORE quietly removing its children

Status: VERIFIED FIXED

(Core Graveyard :: RDF, defect, P3)

Description

[Brian Ryner (not reading)]

When removing all content from a tree, the template builder currently removes
all of the children of the <treechildren> directly, then removes and reinserts
the <treechildren> at the end so the tree will notice.  This causes the tree to
be in an inconsistent state during these removals, which can cause a crash with
my checkin to fix bug 42109.

If the treechildren was first removed, then the tree should correctly report
that it has 0 rows.

Comment 1

[Brian Ryner (not reading)]

rginda, it seems that my patch for this might fix the chatzilla problem you were
seeing.

Comment 2

[Brian Ryner (not reading)]

Attachment: patch

Comment 3

[Brian Ryner (not reading)]

Attachment: patch #2

Comment 4

[Brian Ryner (not reading)]

Attached a new patch waterson says should be better.

putterman, would you mind giving this a try and see if you can find any odd
behavior or problems?

Comment 5

[Robert Ginda]

This does indeed fix chatzilla.  Also, I checked out mailnews (created an IMAP
account, retrieved messages, read a few) and didn't notice any *new*
regressions.

Comment 6

[Chris Waterson]

bryner, didn't you fix this? If not, check in your patch, r=waterson.

Comment 7

[Chris Waterson]

giving bryner the glory

Comment 8

[Brian Ryner (not reading)]

Marking dependency... this is also causing chatzilla crashes, although I don't
have the bug number for that.

Comment 9

[Robert Ginda]

*** Bug 49410 has been marked as a duplicate of this bug. ***

Comment 10

[Brian Ryner (not reading)]

Checked in a fix.

Comment 11

[Brian Ryner (not reading)]

yep, we do this in the right order now in the template builder.