When removing all content from a tree, the template builder currently removes all of the children of the <treechildren> directly, then removes and reinserts the <treechildren> at the end so the tree will notice. This causes the tree to be in an inconsistent state during these removals, which can cause a crash with my checkin to fix bug 42109. If the treechildren was first removed, then the tree should correctly report that it has 0 rows.
rginda, it seems that my patch for this might fix the chatzilla problem you were seeing.
Attached a new patch waterson says should be better. putterman, would you mind giving this a try and see if you can find any odd behavior or problems?
This does indeed fix chatzilla. Also, I checked out mailnews (created an IMAP account, retrieved messages, read a few) and didn't notice any *new* regressions.
bryner, didn't you fix this? If not, check in your patch, r=waterson.
giving bryner the glory
Marking dependency... this is also causing chatzilla crashes, although I don't have the bug number for that.
*** Bug 49410 has been marked as a duplicate of this bug. ***
Checked in a fix.
yep, we do this in the right order now in the template builder.