Closed Bug 50554 Opened 24 years ago Closed 24 years ago

Need to remove treechildren BEFORE quietly removing its children

Categories

(Core Graveyard :: RDF, defect, P3)

x86
Linux
defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: bryner, Assigned: bryner)

References

Details

Attachments

(2 files)

When removing all content from a tree, the template builder currently removes
all of the children of the <treechildren> directly, then removes and reinserts
the <treechildren> at the end so the tree will notice.  This causes the tree to
be in an inconsistent state during these removals, which can cause a crash with
my checkin to fix bug 42109.

If the treechildren was first removed, then the tree should correctly report
that it has 0 rows.
rginda, it seems that my patch for this might fix the chatzilla problem you were
seeing.
Attached patch patchSplinter Review
Attached patch patch #2Splinter Review
Attached a new patch waterson says should be better.

putterman, would you mind giving this a try and see if you can find any odd
behavior or problems?
This does indeed fix chatzilla.  Also, I checked out mailnews (created an IMAP
account, retrieved messages, read a few) and didn't notice any *new*
regressions.
bryner, didn't you fix this? If not, check in your patch, r=waterson.
giving bryner the glory
Assignee: waterson → bryner
Marking dependency... this is also causing chatzilla crashes, although I don't
have the bug number for that.
Blocks: 47795
Status: NEW → ASSIGNED
*** Bug 49410 has been marked as a duplicate of this bug. ***
Blocks: 47673
Checked in a fix.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
yep, we do this in the right order now in the template builder.
Status: RESOLVED → VERIFIED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: