505584 - TM: fast path for traced JSOP_ARGUMENTS

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[David Mandelin [:dmandelin]]

The existing implementation always calls a function to get |arguments|. I did it that way because the value is computed conditionally either by reading from the stack or creating the object. But conditionals aren't too hard with nanojit: you can store to memory in each branch and then read out after. It is probably better to have a fast path to read |arguments| from the stack without calling.

Comment 1

[David Mandelin [:dmandelin]]

This got fixed as part of bug 504797.

Comment 2

[Brendan Eich [:brendan]]

FIXED, then -- WFM is "we don't know why, but it works for us", drink beer, be happy ;-).

/be

Comment 3

[Brendan Eich [:brendan]]

FIXED is drink beer, be happy too, of course :-).

/be