505601 - Remove SharedMenuCocoa

Status: RESOLVED FIXED

(Camino Graveyard :: Toolbars & Menus, defect)

Description

[Stuart Morgan]

I was poking at the SMC warnings today, and was inspired to go see if this wildly-out-of-date code is really still the state of the art for the program it's meant for, and/or if that program was dead.

I found this fascinating tidbit in the URL Manager Pro docs:

"We prefer you use the Bookmark Menu Extra, but you may still want to use the Shared Menus feature instead. [...] Shared Menus are mainly still supported for users of URL Manager who come from Mac OS 9.

Note: Shared Menus are not supported on Intel Macs."

So... the author doesn't recommend that anyone use it any more, there's a replacement interface using modern OS X technology that doesn't require us to keep shipping that code, and it already doesn't work for something like 2/3 of our users. Oh, and there's a haxie for people who really really want it Shared Menus in arbitrary apps that don't build it in.


Is there a good reason not to rip it out of the app and the tree?

Comment 1

[Mike Pinkerton (not reading bugmail)]

make it so.

Comment 2

[Stuart Morgan]

Attachment: stop building SMC

I'm going to land this in two parts, one to stop building SMC, and then another to actually remove all the source. Here's part one (part two I won't make a patch for, since it'll just be file removal).

Comment 3

[Stuart Morgan]

Part one landed on CVS trunk and CAMINO_2_0_BRANCH. Leaving open for part two once tinderbox cycles.

Comment 4

[Stuart Morgan]

Source removed on CVS trunk and CAMINO_2_0_BRANCH.

Comment 5

[Markus Amalthea Magnuson]

There are still some traces of SMC on various wiki pages, that might need to be reviewed: http://wiki.caminobrowser.org/Special:Search?search=shared+menus&go=Go

Comment 6

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Those all describe branches on which the framework still exists.

Comment 7

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Don't tell ld where to look for the framework

I happened to be watching minus just as the warning about this scrolled by…what, why is ld looking for a path that doesn't exist for a framework we no longer build?  mxr knew why ;)

Comment 8

[Stuart Morgan]

Comment on attachment 398582 [details] [diff] [review]
Don't tell ld where to look for the framework

Oops!
sr=me

Comment 9

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

(In reply to comment #8)
> (From update of attachment 398582 [details] [diff] [review])

Landed that on cvs trunk and CAMINO_2_0_BRANCH.