Closed
Bug 505728
Opened 15 years ago
Closed 13 years ago
_wrap_image leaks data if cairo_image_surface_create_for_data fails
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
DUPLICATE
of bug 526976
People
(Reporter: timeless, Assigned: timeless)
References
(Blocks 1 open bug, )
Details
(Keywords: coverity, memory-leak)
Attachments
(1 file, 1 obsolete file)
|
601 bytes,
patch
|
jrmuizel
:
review-
|
Details | Diff | Splinter Review |
1313 struct acquire_source_image_data *data = malloc(sizeof(*data)); this function call will only adopt data if it's successful, on failure, the data is ours, and it's our job to free it: 1318 surface = (cairo_image_surface_t*)cairo_image_surface_create_for_data (image->data, 1323 status = surface->base.status; here we leak it: 1324 if (status) 1325 return status;
Attachment #390174 -
Flags: review?(vladimir) → review?(jmuizelaar)
Attachment #390174 -
Attachment is obsolete: true
Attachment #391613 -
Flags: review?(jmuizelaar)
Attachment #390174 -
Flags: review?(jmuizelaar)
|
||
Comment 3•14 years ago
|
||
Comment on attachment 391613 [details] [diff] [review] updated reviewer I believe this is already fixed.
Attachment #391613 -
Flags: review?(jmuizelaar) → review-
|
||
Comment 4•13 years ago
|
||
Fixed as part of bug 526976
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → DUPLICATE
|
||
Updated•6 years ago
|
Blocks: coverity-analysis
You need to log in
before you can comment on or make changes to this bug.
Description
•