Closed Bug 505734 Opened 15 years ago Closed 15 years ago

mozStorageStatementParams.cpp compilation fails on MinGW.

Categories

(Toolkit :: Storage, defect)

Product:
Toolkit
Component:
Storage
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9.2b1

People

(Reporter: jacek, Assigned: jacek)

References

Details

Attachments

(1 file, 3 obsolete files)

Fix
1.37 KB, patch
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.1) Gecko/20090715 Firefox/3.5.1
Build Identifier: 

On MinGW jschar != PRUnichar so we have to cast strings explicitly in NS_ConvertUTF16toUTF8 calls.

Reproducible: Always
Attached patch Fix (obsolete) — — Splinter Review 

        Attachment #389935 -
        Flags: review?(bugmail)
Assignee: Jan.Varga → nobody
Component: SQL → Storage
Product: Core → Toolkit
QA Contact: irixman+bugzilla → storage

        Attachment #389935 -
        Flags: review?(bugmail) → review?(sdwilsh)

    
    

    
  
Comment on attachment 389935 [details] [diff] [review]
Fix

No C-style casts.  You'll probably want to use a temporary too.

        Attachment #389935 -
        Flags: review?(sdwilsh) → review-

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Fix with reinterpret_cast (obsolete)
        — 
          — Splinter Review
      

    


  
I've changed the patch to use reinterpret_cast, as suggested by Boris Zbarsky in bug 505727.

        Attachment #389935 -
        Attachment is obsolete: true

        Attachment #390022 -
        Flags: review?(sdwilsh)

    
    

    
  
Please wrap the lines at 80 characters (see http://mxr.mozilla.org/mozilla-central/source/storage/style.txt)
Assignee: nobody → jacek
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true

        Attachment #390022 -
        Flags: review?(sdwilsh)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Fix (obsolete)
        — 
          — Splinter Review
      

    


  
Thanks for the review. Here is a fixed patch.

        Attachment #390022 -
        Attachment is obsolete: true

        Attachment #392702 -
        Flags: review?(sdwilsh)
Blocks: 508905

        Attachment #392702 -
        Flags: review?(sdwilsh) → review+

    
    

    
  
Comment on attachment 392702 [details] [diff] [review]
Fix

r=sdwilsh with one nit that I missed before:
please use "reinterpret_cast<const PRUnichar *>" (space before *).

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Fix
        — 
          — Splinter Review
      

    


  
Thanks for the review. The fixed patch is attached.

        Attachment #392702 -
        Attachment is obsolete: true

        Attachment #393353 -
        Flags: review+

    
  
Keywords: checkin-needed

    
  

        Attachment #393353 -
        Flags: review+

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/c97c0621f626
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2b1

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: