Fix nsDOMStorage.cpp:CheckSecure code to not mask by IsSecure() result, coverity doesn't like it

RESOLVED FIXED

Status

()

RESOLVED FIXED
9 years ago
2 months ago

People

(Reporter: mayhemer, Assigned: mayhemer)

Tracking

(Blocks: 1 bug, {coverity})

Trunk
coverity
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
Use 'if (IsSecure()) { *secure = PR_TRUE; return PL_DHASH_STOP; }'
(Assignee)

Comment 1

9 years ago
Created attachment 393490 [details] [diff] [review]
v1 [Checkin comment 2]
Assignee: nobody → honzab.moz
Status: NEW → ASSIGNED
Attachment #393490 - Flags: review?
(Assignee)

Updated

9 years ago
Attachment #393490 - Flags: review? → review?(timeless)

Updated

9 years ago
Attachment #393490 - Flags: review?(timeless) → review+
(Assignee)

Comment 2

9 years ago
Comment on attachment 393490 [details] [diff] [review]
v1 [Checkin comment 2]

http://hg.mozilla.org/mozilla-central/rev/bbf81d249ebd
Attachment #393490 - Attachment description: v1 → v1 [Checkin comment 2]
(Assignee)

Updated

9 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Component: DOM: Mozilla Extensions → DOM
Product: Core → Core
Blocks: 1230156
You need to log in before you can comment on or make changes to this bug.