Closed
Bug 505784
Opened 15 years ago
Closed 15 years ago
nuke STANDALONE mode in libjar
Categories
(Core :: Networking: JAR, defect)
Tracking
()
VERIFIED
FIXED
mozilla1.9.2a1
People
(Reporter: taras.mozilla, Assigned: taras.mozilla)
References
Details
Attachments
(2 files)
519 bytes,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
22.25 KB,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
It causes ugly header hacks which make it rather unpleasant to work on jar stuff.
Assignee | ||
Comment 1•15 years ago
|
||
Assignee: nobody → tglek
Attachment #390009 -
Flags: review?(benjamin)
Comment 2•15 years ago
|
||
Comment on attachment 390009 [details] [diff] [review]
disable standalone jar build
Please remove modules/libjar/standalone completely
Updated•15 years ago
|
Attachment #390009 -
Flags: review?(benjamin) → review+
Assignee | ||
Comment 3•15 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/1b2d393274a3
leaving bug open for further STANDALONE nuking.
Comment 4•15 years ago
|
||
"can't read .../modules/libjar/standalone/Makefile.in: No such file or directory"
Please, remove the following line too:
/toolkit/toolkit-makefiles.sh
* line 291 -- modules/libjar/standalone/Makefile
Assignee | ||
Comment 5•15 years ago
|
||
(In reply to comment #4)
> "can't read .../modules/libjar/standalone/Makefile.in: No such file or
> directory"
>
thanks. rolled that into this patch
Attachment #390274 -
Flags: review?(benjamin)
Updated•15 years ago
|
Attachment #390274 -
Flags: review?(benjamin) → review+
Assignee | ||
Comment 6•15 years ago
|
||
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Updated•15 years ago
|
Flags: in-testsuite-
Target Milestone: --- → mozilla1.9.2a1
Comment 7•15 years ago
|
||
There was already a bug for this: bug 272451.
I have closed that one as fixed by this one.
Updated•15 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•