Closed Bug 505841 Opened 15 years ago Closed 6 years ago

ccx.GetWrapper() should be null checked

Categories

(Core :: XPConnect, defect)

defect
Not set
critical

Tracking

()

RESOLVED INACTIVE

People

(Reporter: timeless, Assigned: timeless)

References

(Blocks 1 open bug, )

Details

(Keywords: coverity, crash)

Attachments

(1 file)

2.64 KB, patch
timeless
: review?
dbradley
Details | Diff | Splinter Review
there are three places in our code which don't null check ccx.GetWrapper(), two are in XPCWrapper.cpp. I'm sure I'll find the third shortly.
Attached patch patchSplinter Review
Assignee: nobody → timeless
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #393730 - Flags: review?(dbradley)
For what it's worth, I believe the null checks in XPCWrapper.cpp are redundant since the only callers of those functions must have XPCWrappedNatives. But if it'll reduce coverity noise, then I suppose it's worth it.
Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → INACTIVE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: