ccx.GetWrapper() should be null checked

RESOLVED INACTIVE

Status

()

--
critical
RESOLVED INACTIVE
9 years ago
a month ago

People

(Reporter: timeless, Assigned: timeless)

Tracking

(Blocks: 1 bug, {coverity, crash})

Trunk
coverity, crash
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

2.64 KB, patch
timeless
: review?
dbradley
Details | Diff | Splinter Review
(Assignee)

Description

9 years ago
there are three places in our code which don't null check ccx.GetWrapper(), two are in XPCWrapper.cpp. I'm sure I'll find the third shortly.
(Assignee)

Comment 1

9 years ago
Created attachment 393730 [details] [diff] [review]
patch
Assignee: nobody → timeless
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #393730 - Flags: review?(dbradley)
For what it's worth, I believe the null checks in XPCWrapper.cpp are redundant since the only callers of those functions must have XPCWrappedNatives. But if it'll reduce coverity noise, then I suppose it's worth it.

Comment 3

3 months ago
Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.
Status: ASSIGNED → RESOLVED
Last Resolved: 3 months ago
Resolution: --- → INACTIVE
You need to log in before you can comment on or make changes to this bug.