Closed
Bug 505857
Opened 15 years ago
Closed 15 years ago
CategoryNode::AddLeaf can return without unlocking mLock
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
People
(Reporter: timeless, Assigned: benjamin)
References
(Blocks 1 open bug, )
Details
(Keywords: coverity, hang)
Attachments
(1 file)
|
12.04 KB,
patch
|
timeless
:
review+
|
Details | Diff | Splinter Review |
289 CategoryNode::AddLeaf(const char* aEntryName,
296 PR_Lock(mLock);
300 nsresult rv = NS_OK;
301 if (leaf) {
304 rv = NS_ERROR_INVALID_ARG;
305 } else {
308 rv = NS_ERROR_OUT_OF_MEMORY;
312 rv = NS_ERROR_OUT_OF_MEMORY;
319 rv = NS_ERROR_OUT_OF_MEMORY;
324 *_retval = ToNewCString(nsDependentCString(toDup));
325 if (!*_retval)
326 return NS_ERROR_OUT_OF_MEMORY;
339 PR_Unlock(mLock);
|
Assignee | |
Comment 1•15 years ago
|
||
|
|
Assignee | |
Updated•15 years ago
|
Attachment #390063 -
Flags: review? → review?(timeless)
Comment on attachment 390063 [details] [diff] [review] Fix locking, use mozilla::Mutex, rev. 1 someday someone should clean up that function now that it's using an autolock :)
Attachment #390063 -
Flags: review?(timeless) → review+
|
|
Assignee | |
Comment 3•15 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/d18fc4202739
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Blocks: coverity-analysis
You need to log in
before you can comment on or make changes to this bug.
Description
•