Closed Bug 505909 Opened 16 years ago Closed 16 years ago

remove Assembler::_startingIns legacy error recovery code in Assembler

Categories

(Tamarin Graveyard :: Baseline JIT (CodegenLIR), defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: edwsmith, Assigned: edwsmith)

References

Details

Attachments

(1 file)

when Assembler encounters an error, it returns partially used code memory back to CodeAlloc, by calling CodeAlloc::free(). Next assembly pass will allocate more code memory by calling CodeAlloc::alloc(). Therefore, _startingIns, and the code to reset _nIns = _startingIns on error, is no longer necessary. on ARM this includes _startingSlot as well.
Blocks: 503556
Assignee: nobody → edwsmith
Attachment #390125 - Flags: review?(rreitmai)
Attachment #390125 - Attachment is patch: true
Attachment #390125 - Attachment mime type: application/octet-stream → text/plain
since Assembler no longer rewinds back to startingIns on error, it also appears that the constant LARGEST_UNDERRUN_PROT isn't needed anymore. after this patch, in tamarin-redux, L.U.P. is only used to determine the minimum size of a block returned by codeAlloc(). however if we actually pass a requested minimum size into codeAlloc (when called from underrunProtect() with a specific size argument), then the constant isn't needed. sound right/wrong anyone?
Attachment #390125 - Flags: review?(rreitmai) → review+
Comment on attachment 390125 [details] [diff] [review] remove unnecssary startingIns tracking So _nSlot is getting initialized in nativePageSetup() ?
(In reply to comment #3) > (From update of attachment 390125 [details] [diff] [review]) > So _nSlot is getting initialized in nativePageSetup() ? correct
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Resolved fixed engineering / work item that has been pushed. Setting status to verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: