Closed Bug 5060 Opened 25 years ago Closed 25 years ago

[Necko] [DOGFOOD BLOCK] My netscape does not layout properly

Categories

(Core :: Layout, defect, P3)

Product:
Core
Component:
Layout
Platform:
All
Windows NT
Type:
defect

Tracking

()

Status:
VERIFIED WORKSFORME

People

(Reporter: nisheeth_mozilla, Assigned: nisheeth_mozilla)

References

(
URL
)

Details

(Whiteboard: fix in hand. Awaiting permission to check in...) 

Cache a copy of my.netcape.com locally if you can't get my.netscape.com to load.
When you access this file in the browser, the layout is messed up: layers
overlap each other and make the content unreadable.
Status: NEW → ASSIGNED
Target Milestone: M5
Accepting bug and setting target milestone to M5...
Target Milestone: M5 → M6
Moving to M6...
Nisheeth,  is this high on the priority list for M6?  the sooner we can
get my.netscape.com off the floor the closer we will be to browser dogfood
and have lots of people using the daily builds.  thanks.
Nisheeth,  is this high on the priority list for M6?  the sooner we can
get my.netscape.com off the floor the closer we will be to browser dogfood
and have lots of people using the daily builds.  thanks.
*** Bug 6563 has been marked as a duplicate of this bug. ***
Whiteboard: fix in hand. Awaiting permission to check in...
I have a fix for this and I need permission to check in on the M6 branch.

There were two problems here.  One, the LEFT attribute on the LAYER tag was not
processing percentage values properly.  Two, the parser was not nesting LAYER
tags properly.

Changes to nsElementTable.cpp and nsHTMLLayerElement.cpp are required.  QA
impact should be minimal.
Just tested this against the May26 second and final M6 build.  Still does not
load.  www.slashdot.org looks much better though :-)  If this cannot get fixed
until Necko landing, please move Target Milestone to M8.
A copy of the email I sent to chofmann describing the current state of affairs
for my.netscape.com:

-----
The fix affects two files, one in the parser, one in layout.  There were two
problems: a) the parser was not letting layer tags nest within layer
tags, b) layout was not accepting percentage values for the LEFT and TOP
attributes on the LAYER tag.

The fix does not look risky because it is very localized.

There are other non-layout issues with my.netscape.com which prevent it from
displaying properly for now:

a) There is a netlib issue which prevents the page from loading properly over
the network.  A bug is assigned to Gagan about this which will
probably get fixed when Necko lands.
b) Javascript entities are used to determine the position of the layers on the
page.  The HTML parser currently does not have support for
these entities which results in the layout of the page getting skewed.  Rick
Gessner has javascript entity implementation on his plate.

------
Target Milestone: M6 → M8
Moving this bug to M8 because it depends on the Necko landing...
Blocks: 7922
Summary: {DOGFOOD BLOCK] My netscape does not layout properly → [Necko] [DOGFOOD BLOCK] My netscape does not layout properly
Updating summary to show dependency on Necko.
Problem still occuring in June 28th Build. Loading this page in Mac version will
cause a crash.
Target Milestone: M8 → M9
Moving out Necko related bugs to M9...
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → WORKSFORME
Target Milestone: M9 → M8
This is working in the latest builds.  I'm guessing that some netlib/necko fixes
for M8 fixed this problem.  Marking worksforme.
Status: RESOLVED → VERIFIED
With the July 12th build (1999071218) Mac, Windows, an Linux builds, my.netscape
loads and displays the content correctly. Marking Works for me.
No longer blocks: 7922
You need to log in before you can comment on or make changes to this bug.