Closed Bug 506001 Opened 11 years ago Closed 11 years ago

[Port Bug 505700] Don't allow moving the window with the toolbar while in fullscreen mode.

Categories

(SeaMonkey :: UI Design, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.0b2

People

(Reporter: philip.chee, Assigned: philip.chee)

References

Details

Attachments

(1 file)

Mnyromyr thinks we should also do this. CC stefanh to confirm since this is OSX specific.
Toolkit does this:
>-            return !this.parentNode.customizing; // Don't move while customizing.
>+            // Don't move while customizing or while in full screen mode.
>+            return !this.parentNode.customizing && !window.fullScreen;

I did it this way instead so that it matches the comment.
+              return !(this.parentNode.customizing || window.fullScreen);
Attachment #390226 - Flags: superreview?(neil)
Attachment #390226 - Flags: review?(neil)
Comment on attachment 390226 [details] [diff] [review]
Patch v1.0
[Checkin: Comment 10]

switching review to stefanh since he has a Mac and I don't
Attachment #390226 - Flags: review?(neil) → review?(stefanh)
Comment on attachment 390226 [details] [diff] [review]
Patch v1.0
[Checkin: Comment 10]

Nit: wrong amount of indent on the comment.
Attachment #390226 - Flags: superreview?(neil) → superreview+
> Nit: wrong amount of indent on the comment.
Fixed locally. Now all I need is for someone to test this on a Mac.
AFAIK this will only work if you add ui for it and pull with a mozilla-central tree.
(In reply to comment #5)
> AFAIK this will only work if you add ui for it and pull with a mozilla-central
> tree.

(By "this" I mean full screen mode)
> AFAIK this will only work if you add ui for it and pull with a mozilla-central
> tree.
But it does no harm to do this now least we forget when we eventually move to 1.9.{2|3|4}, right?
(In reply to comment #7)
> > AFAIK this will only work if you add ui for it and pull with a mozilla-central
> > tree.
> But it does no harm to do this now least we forget when we eventually move to
> 1.9.{2|3|4}, right?

Sure. I just wanted to explain that even though the patch is really simple it'll take some time before I've tested this. I'll need fullscreen ui for mac and then a tree with m-c.
Attachment #390226 - Flags: review?(stefanh) → review+
Comment on attachment 390226 [details] [diff] [review]
Patch v1.0
[Checkin: Comment 10]

Wasn't that difficult to test as I thought ;-)
Keywords: checkin-needed
Comment on attachment 390226 [details] [diff] [review]
Patch v1.0
[Checkin: Comment 10]


http://hg.mozilla.org/comm-central/rev/6c76d904691b
Attachment #390226 - Attachment description: Patch v1.0 → Patch v1.0 [Checkin: Comment 10]
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.0b2
You need to log in before you can comment on or make changes to this bug.