506019 - Default Theme: Messages Do Not Display in Separate Window

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[TommyBee (No E-mail)]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1.1pre) Gecko/20090718 SeaMonkey/2.0b1
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1.1pre) Gecko/20090718 SeaMonkey/2.0b1

I just updated from 2.0a3 to 2.0b1 on two separate machines, and on both I am unable to view IMAP message contents in a separate window (the preview pane works fine).  The message toolbar at the top appears, but the rest of the window is blank.  This problem does not appear to affect 2.0b1 on Windows Vista with SP2 -- only on Mac OS X Leopard (10.5.7).

Reproducible: Always

Steps to Reproduce:
1. Launch SeaMonkey.
2. Open the Mail/News component.
3. Double-click on a message in an IMAP mailbox.
Actual Results:  
The window appears with the toolbar at the top but no contents below it.

Expected Results:  
The window appears with the toolbar at the top, the message headers below it, and the message content in the remainder of the window.

Comment 1

[TommyBee (No E-mail)]

Correction:  this affect both POP and IMAP (I couldn't check this on my work computer).

Comment 2

[TommyBee (No E-mail)]

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1.2pre) Gecko/20090724 SeaMonkey/2.0b2pre also contains this bug, so it wasn't an anomaly to the 2.0b1 build.

Comment 3

[TommyBee (No E-mail)]

Back to 2.0b1, I tried viewing messages with the Modern theme instead of the default theme, and the message windows worked properly.  Could this be an issue with the theme itself rather than the message display window?

Comment 4

[Robert Kaiser]

Frank and Karsten are apparently investigating this - is this bug report a dupe or is it the one where we should get that patch in once we find it?

As a note: This is Mac only, Linux and Windows are not affected - we're not sure yet why that is though.

Comment 6

[Frank Wein [:mcsmurf]]

(In reply to comment #4)
> As a note: This is Mac only, Linux and Windows are not affected - we're not
> sure yet why that is though.

Seems to be some strange(?) behavior of XPCOM, calling addObserver (nsIPrefBranch2) on a nsIPrefBranch object in JS seems to work fine on Windows and Linux, but not on Mac.

Comment 7

[Karsten Düsterloh]

Attachment: always use nsIPrefBranch2

The messenger window makes sure to cast the global pref var to nsIPrefBranch2 in msgMail3PaneWindow.js::OnLoadMessenger, but the messageWindow doesn't. Both do call the same function to initialize so pref, so we could just as well make it an nsIPrefBranch2 in the first place...

Patch written on Mac and tested under Linux.

Comment 8

[[e-mail]]

(In reply to comment #3)
> Back to 2.0b1, I tried viewing messages with the Modern theme instead of the
> default theme, and the message windows worked properly.  Could this be an issue
> with the theme itself rather than the message display window?
You've hit the nail on the head!

The Mac Classic theme uses its own grippytoolbar-drag binding rather than the old grippytoolbar-primary binding that we keep in order to honour the browser.chrome.toolbar_style preference. And it is this toolbar preference code that has the side effect of making the message window work...

Comment 9

[Karsten Düsterloh]

Pushed as <http://hg.mozilla.org/comm-central/rev/ea57778deaea>.

Comment 10

[TommyBee (No E-mail)]

Verified fixed in build 20090727002647; with the Mac Classic theme in use, message windows now display the headers and contents as expected.

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1.2pre) Gecko/20090727 SeaMonkey/2.0b2pre

Thanks for the quick turnaround!