506166 - [ForumUX] Add status and icon for when the original commenter replies

Status: VERIFIED FIXED

(support.mozilla.org :: Forum, task, P3)

Description

[[:Cww]]

We'd like to know if the original commenter has come and answered a request for info or given more details and those threads are ready for followup.  Give a status and icon for these.

Comment 1

[Laura Thomson :laura]

Is Marius working on an icon for this one?

Comment 2

[Paul Craciunoiu [:paulc]]

Yes. I let him know to try and have the icons ready this week.

Comment 3

[[:marius]]

Attachment: original-commenter.png

Would this work as the icon?

Comment 4

[[:Cww]]

Looks good.

Comment 5

[[:Cww]]

Do we have the backend code for putting in a new status (g?)

Comment 6

[Paul Craciunoiu [:paulc]]

Not yet. Not terribly complicated, though.

Comment 7

[Laura Thomson :laura]

No patch -> 1.4.1

Comment 8

[Paul Craciunoiu [:paulc]]

Attachment: v1

I copied the attached icon to: webroot/img/silk/original.png
This patch adds a pref (just realized this needs to be added the whiteboard, and hence, to our practices -- added changepref). The reason for the pref is upstreaming, of course.

Comment 9

[James Socol [:jsocol, :james]]

I applied the patch and added the pref, but I can't make it happen. I notice that it changes the status to 'u', but my database still has 'r'. Am I missing a step?

Comment 10

[Paul Craciunoiu [:paulc]]

Not sure what to say. Did you enable the pref at tiki-admin.php?page=forums ?
I applied the patch and tested again, logged in and out, and it works for me. Steps I took:
1. Apply patch.
2. Enable pref at tiki-admin.php?page=forums
3. Test, both logged in and out (creating a new thread each time).

When you enable the pref, there should be a message at the top (post-submit): "feature_forum_thread_status_original enabled"

Comment 11

[James Socol [:jsocol, :james]]

I'll try again. I enabled the pref via MySQL, maybe doing it that way missed something.

Comment 12

[James Socol [:jsocol, :james]]

Attachment: original poster logged in

Ok, not sure if I missed something last time, but the 'u' status is there now. Except, it's there immediately after I reply with a different user. The steps were:

1. Post a thread (logged in or not)
2. In another browser, respond (I've tried "request more info" and "none of the above")

The thread is already set to 'u' and the "original.png" icon is there.

Comment 13

[James Socol [:jsocol, :james]]

Attachment: another view, both users anonymous

Comment 14

[Paul Craciunoiu [:paulc]]

Attachment: v2

This should do it. I tested some for anon-posted and user-posted threads.

Comment 15

[James Socol [:jsocol, :james]]

Comment on attachment 407590 [details] [diff] [review]
v2

Works great!

Comment 16

[Paul Craciunoiu [:paulc]]

r54049 (trunk)

Comment 17

[Stephen Donner [:stephend] Not actively reading bugmail]

I enabled this over at http://support-stage.mozilla.org/tiki-admin.php?page=forums.  Pref is "Change forum thread status when original author replies".  Still not seeing the original-poster icon over at test threads such as http://support-stage.mozilla.org/en-US/forum/1/447020? (which should actually show up on the forum-index view @ http://support-stage.mozilla.org/en-US/forum/1, right?

Maybe it's caching, and I should wait a bit.

Comment 18

[Stephen Donner [:stephend] Not actively reading bugmail]

http://support-stage.mozilla.org/img/silk/original.png exists, so I don't know what the deal is :-(

Comment 19

[Paul Craciunoiu [:paulc]]

Was the thread replied-to after this patch landed?

Comment 20

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #19)
> Was the thread replied-to after this patch landed?

It has timestamps, but yes, created *and* replied to after the patch landed; can one of you guys try it?

Comment 21

[Stephen Donner [:stephend] Not actively reading bugmail]

Reopening until I see this working.

Comment 22

[Paul Craciunoiu [:paulc]]

It worked for me...
Logged in:
https://support-stage.mozilla.org/en-US/forum/1/447028
Logged out:
https://support-stage.mozilla.org/en-US/forum/1/447030

Comment 23

[James Socol [:jsocol, :james]]

Resolved on Stephen's request.

Comment 24

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; WFM too.  Sorry for the noise.

Verified on both the URLs in comment 22, as well as my own testing in http://support-stage.mozilla.org/en-US/forum/1/447035? (anon) and https://support-stage.mozilla.org/en-US/forum/1/447038 (logged-in user).

Comment 25

[Stephen Donner [:stephend] Not actively reading bugmail]

Wrote https://litmus.mozilla.org/show_test.cgi?id=9678 for the anon case, and https://litmus.mozilla.org/show_test.cgi?id=9677 for the logged-in-user case.

:-)

Comment 26

[Paul Craciunoiu [:paulc]]

r54613 (prod)

Comment 27

[Chris Ilias [:cilias]]

feature_forum_thread_status_original enabled on prod.

Comment 28

[[:Cww]]

feature_forum_thread_status_original disabled on prod because the icon wasn't checked into SVN so we're seeing broken image links.

Comment 29

[Paul Craciunoiu [:paulc]]

*sighs* my bad...

Comment 30

[Paul Craciunoiu [:paulc]]

This is fixed on trunk and we'll be tagging from there => bug closed.

Comment 31

[Stephen Donner [:stephend] Not actively reading bugmail]

This can't really be fixed until we push 1.5 to prod, right?  And the only thing to verify there is the missing image is back, yeah?

Comment 32

[[:Cww]]

Yeah, I just have to re-enable the pref once 1.5 pushes.

Comment 33

[[:Cww]]

reset pref on prod, pls re-verify

Comment 34

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Post-fix screenshot, on prod

Comment 35

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED.