Closed Bug 506171 Opened 11 years ago Closed 11 years ago

IPDL: rewrite passes that lower from IPDL to C++ so that native IPDL arrays can be added

Categories

(Core :: IPC, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: cjones, Assigned: cjones)

References

Details

Attachments

(2 files, 2 obsolete files)

This code (ipdl/lower.py) is bursting at the seams and getting difficult for me to maintain.  I doubt anyone else would be able to add a feature or fix a bug.  Now that it's nearly feature complete, time for refactoring.
Summary: IPC: rewrite passes that lower from IPDL to C++ → IPDL: rewrite passes that lower from IPDL to C++
Blocks: 516524
Summary: IPDL: rewrite passes that lower from IPDL to C++ → IPDL: rewrite passes that lower from IPDL to C++ so that native IPDL arrays can be added
Blocks: 519813
Attached patch backup purposes only (obsolete) — Splinter Review
Should be done tomorrow, all that's left is serializing/deserializing unions and polish.
Attached patch fix (obsolete) — Splinter Review
Final version, for all intents and purposes.  Passes IPDL-compiler-only unit tests and compiles all our current IPDL code.  The generated C++ still has a few bugs I need to iron out, but these will be minor tweaks.
Attachment #406391 - Attachment is obsolete: true
Attachment #406641 - Flags: review?(bent.mozilla)
Attached patch fix, fixedSplinter Review
Back up to parity with the old code, and passing the simplest array unit test.  But need sleepy now.
Attachment #406641 - Attachment is obsolete: true
Attachment #406668 - Flags: review?(bent.mozilla)
Attachment #406641 - Flags: review?(bent.mozilla)
Comment on attachment 406668 [details] [diff] [review]
fix, fixed

Sold!
Attachment #406668 - Flags: review?(bent.mozilla) → review+
Pushed http://hg.mozilla.org/projects/electrolysis/rev/f1e79cb59195
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.