506171 - IPDL: rewrite passes that lower from IPDL to C++ so that native IPDL arrays can be added

Status: RESOLVED FIXED

(Core :: IPC, enhancement)

Description

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

This code (ipdl/lower.py) is bursting at the seams and getting difficult for me to maintain.  I doubt anyone else would be able to add a feature or fix a bug.  Now that it's nearly feature complete, time for refactoring.

Comment 1

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: backup purposes only

Should be done tomorrow, all that's left is serializing/deserializing unions and polish.

Comment 2

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: fix

Final version, for all intents and purposes.  Passes IPDL-compiler-only unit tests and compiles all our current IPDL code.  The generated C++ still has a few bugs I need to iron out, but these will be minor tweaks.

Comment 3

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: fix, fixed

Back up to parity with the old code, and passing the simplest array unit test.  But need sleepy now.

Comment 4

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: anti-patch to get array patch to aplpy cleanly

Comment 5

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 406668 [details] [diff] [review]
fix, fixed

Sold!

Comment 6

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Pushed http://hg.mozilla.org/projects/electrolysis/rev/f1e79cb59195