506322 - Today pane collapse/expand buttons should always react to first click

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[Merike Sell (:merike)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; et; rv:1.9.1.1) Gecko/20090715 Firefox/3.5.1 (.NET CLR 3.5.30729)
Build Identifier: 

After focusing on an event in today pane collapse button needs to clicks to work.

Reproducible: Always

Steps to Reproduce:
1. Create an event on tomorrow
2. Make sure tomorrow section is expanded
3. Click on the event in today pane and hit delete
4. Click on collapse button

Actual Results:  
It won't collapse.

Expected Results:  
It should collapse.

A second click on collapse button makes it collapse.

Comment 1

[Philipp Kewisch [:Fallen][📱📆]]

Confirmed, since Clint could reproduce this as noted in the calendar mozmill bug. It would be nice to fix this since there is a mozmill test that uses this feature.

Comment 2

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Fix - v1

Hmm strange stuff. The items were being disabled. This caused clicks to not toggle the checked state correctly. Does anyone know why we needed to disable those items on blur?

Comment 3

[Martin Schröder [:mschroeder]]

Comment on attachment 398873 [details] [diff] [review]
Fix - v1

r=mschroeder, and I don't know the reason for disabling the items on blur, but Berend should!

Comment 4

[Philipp Kewisch [:Fallen][📱📆]]

I'll ask Berend tomorrow.

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/1ebe58064c88>

-> FIXED

Comment 5

[Philipp Kewisch [:Fallen][📱📆]]

Berend told me this was a UI decision: when the focus is not on the today pane, the today pane items should not have the selected color. With the patch above, this is reverted.

What we could do is try to use css rules with the :focus pseudo-selector to make sure it looks normal when not focused, but I think this is also a more general problem we shouldn't start fixing in calendar. For example, the folder pane also remains in the selected color when not focused.