If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Remove Draw*ImageInternal from nsLayoutUtils

RESOLVED FIXED

Status

()

Core
Layout: Misc Code
--
minor
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: Ryo Kawaguchi, Assigned: Ryo Kawaguchi)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
This is a follow-up bug for bug 753.

As a consequence of bug 753, Draw*ImageInternal()'s are no longer necessary and should be merged into Draw*Image()'s.
(Assignee)

Comment 1

8 years ago
Created attachment 390617 [details] [diff] [review]
patch

Remove DrawSingleUnscaledImageInternal and DrawSingleImageInternal.
Remove an irrelevant comment.

I ended up not removing DrawImageInternal(). Each of Draw*Image() returns NS_ERROR_FAILURE when an image to draw has zero size since imgContainer::Init() does not allow zero-sized images to begin with.
(Assignee)

Updated

8 years ago
Attachment #390617 - Flags: review?(roc)
Attachment #390617 - Flags: review?(roc) → review+
(Assignee)

Comment 2

8 years ago
http://hg.mozilla.org/mozilla-central/rev/695b882e085a
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.