Closed Bug 506461 Opened 11 years ago Closed 11 years ago

Change the menupopup id in messenger-overlay-toolbar.xul

Categories

(Calendar :: Lightning Only, defect, trivial)

defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: philip.chee, Assigned: philip.chee)

References

Details

Attachments

(1 file, 1 obsolete file)

I am about to start work on SeaMonkey Bug 16908 which changes the New Message button into a menu-button. It looks like this won't interfere with the overlay in messenger-overlay-toolbar.xul. However I would like to change the id of the menupopup from "button-newmsg-menupopup" to "button-newMsgPopup" to follow the current naming conventions in both Thunderbird and SeaMonkey MailNews. As far as I can tell from MXR, nothing depends on this particular id.
Attached patch Patch v1.0 (obsolete) β€” β€” Splinter Review
"button-newmsg-menupopup" -> "button-newMsgPopup"
Attachment #390647 - Flags: review?(philipp)
Attachment #390647 - Flags: review?(philipp) → review+
Comment on attachment 390647 [details] [diff] [review]
Patch v1.0

Concerns I'd have with this is that someone might likely change this when aligning id style in the future. We haven't really agreed on an id style in Calendar, but we have been using the dash separated style quite often.

Maybe you can add a comment in this specific case, at some point we should align all ids to something as common as possible.

r=philipp with comment added.
Carrying forward r+ from philipp.

> Maybe you can add a comment in this specific case
Fixed.
Attachment #390647 - Attachment is obsolete: true
Attachment #390779 - Flags: review+
Keywords: checkin-needed
Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/3c14886af64c>

-> FIXED
Status: NEW → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 1.0
Target Milestone: 1.0 → 1.0b1
You need to log in before you can comment on or make changes to this bug.