506513 - Fire popuphidden event when popup frame gets destroyed

Status: NEW

(Core :: XUL, defect)

Description

[Dão Gottwald [:dao]]

The Ctrl+Tab and All Tabs panels are hidden in a popuphiding listener (tabPreviewPanelHelper._popuphiding), and apparently this causes the popuphidden event not to be dispatched. The popuphidden handler in popup.xml is expected to reset _prevFocus and _currentFocus, but this doesn't seem to happen in this case.

Comment 1

[Dão Gottwald [:dao]]

Adding the 'access' keyword, as this could also affect panels that don't handle focus restoring themselves.

Comment 2

[Neil Deakin]

Naturally, if there's no frame anymore, there's nothing to fire the event.

Comment 3

[Dão Gottwald [:dao]]

So it's wontfix/invalid from that perspective? Should popup.xml try handle that case?

Comment 4

[Neil Deakin]

It should really be handled in nsXULPopupManager::FirePopupHidingEvent which already restores focus regardlessof whether the frame is present or not. I don't recall or maybe never knew why separate focusing code was added in popup.xml

Comment 5

[Dão Gottwald [:dao]]

Ran into this again in bug 1816496