Closed Bug 506872 Opened 11 years ago Closed 10 years ago

oggplay_seek_cleanup leaks trash when oggplay_buffer_new_buffer fails

Categories

(Core :: Audio/Video, defect, minor)

defect
Not set
minor

Tracking

()

RESOLVED FIXED
Tracking Status
status1.9.2 --- beta1-fixed
status1.9.1 --- .4-fixed

People

(Reporter: timeless, Unassigned)

References

(Blocks 1 open bug, )

Details

(Keywords: coverity, memory-leak)

133 oggplay_seek_cleanup(OggPlay* me, ogg_int64_t milliseconds)
150   trash = oggplay_calloc(1, sizeof(OggPlaySeekTrash));
168 if (me->buffer == NULL) {
169 return;
This is fixed by commit 0cef0c2 in master branch of liboggplay.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
The can't be marked 'resolved fixed' until actually committed to Mozilla trunk.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Fix committed in bug 512328
Status: REOPENED → RESOLVED
Closed: 11 years ago10 years ago
Depends on: CVE-2009-3378
Resolution: --- → FIXED
Fixed on 1.9.1 and 1.9.2 by checkin of bug 512328.
How does QA verify this fix for 1.9.1?
Not really possible I think.
You need to log in before you can comment on or make changes to this bug.