Closed Bug 506986 Opened 12 years ago Closed 8 years ago

When clicking on a folder, Ctrl+Shift should append tabs in the background, not replace in the foreground

Categories

(Firefox :: Tabbed Browser, defect)

3.5 Branch
x86
Windows XP
defect
Not set
normal

Tracking

()

VERIFIED WORKSFORME

People

(Reporter: starcas25, Unassigned)

Details

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.1) Gecko/20090715 Firefox/3.5.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.1) Gecko/20090715 Firefox/3.5.1

(This bug was carved out from Bug 452183 - see for more info)

Currently, a <Ctrl+Shift+click> on a folder in the bookmark sidebar or toolbar replaces the current tab in the foreground and then inserts any remaining tabs before the next existing tab.  As per the discussion in Bug 452183 and Mike's recommendation, this should be changed to appending all the tabs in the background.  This would make it consistent with <Ctrl+Shift+click> on a single bookmark.  Also, as Mike said, "Ctrl+Click, whether or not shift is pressed, should never replace the current tab.  Modifier-click openings should append, like for single bookmarks" to which I concur.

Right now, the "Open All in Tabs" menuitem does the same thing as <Ctrl+Shift+click>, ie replace&insert in the fg, so they may be tied together.  If we change <Ctrl+Shift+click>, I'm not sure if the menuitem should also change or be split off to retain its current behavior.

Reproducible: Always
Blocks: cuts-cruft
No longer blocks: cuts-cruft
Version: unspecified → 3.5 Branch
Please check to see if this reproduces to you in latest nightly using a clean profile:
http://nightly.mozilla.org/

https://support.mozilla.org/en-US/kb/profile-manager-create-and-remove-firefox-profiles#w_creating-a-profile
Flags: needinfo?(starcas25)
Nightly seems to work correctly now.
Flags: needinfo?(starcas25)
Confirmed to be working in Nightly.
Thank you Rick and Nathan!

Marking as verified fixed based on comments 2 and 3.
Status: UNCONFIRMED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
Resolution: FIXED → WORKSFORME
You need to log in before you can comment on or make changes to this bug.