507002 - Port Bug 496832 - Disable media entries in context menu when media source is invalid

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Jens Hatlak (:InvisibleSmiley)]

Attachment: proposed patch

Straight patch, only excluding context-viewvideo which we don't have. See bug 496832 comment 5 for the reasoning behind the .src change.

Comment 1

[[e-mail]]

Comment on attachment 391177 [details] [diff] [review]
proposed patch

>             if ( this.target instanceof Components.interfaces.nsIImageLoadingContent && this.target.currentURI  ) {
>                 this.onImage = true;
>                 var request = this.target.getRequest( Components.interfaces.nsIImageLoadingContent.CURRENT_REQUEST );
>                 if (request && (request.imageStatus & request.STATUS_SIZE_AVAILABLE))
>                     this.onLoadedImage = true;
>-                this.mediaURL = this.target.currentURI.spec;
>+                this.mediaURL = this.target.currentURI.spec || this.target.src;
If you look above you'll see that we don't consider broken images, therefore we don't need to fall back to the src property.

I'm undecided as to whether we should show video items for broken videos yet.

Comment 2

[Jens Hatlak (:InvisibleSmiley)]

Attachment: patch v2

Comment 3

[[e-mail]]

Comment on attachment 391376 [details] [diff] [review]
patch v2

>+        this.setItemAttr( "context-savevideo", "disabled", !this.mediaURL );
Might want to do if (this.onVideo) for this etc.

>+          var hasError = ( this.target.error != null );
Don't need the ()s.

Comment 4

[Jens Hatlak (:InvisibleSmiley)]

Attachment: patch v3 [Checkin: Comment 5]

This is just to make sure I understood you correctly.

Comment 5

[Serge Gautherie (:sgautherie)]

Comment on attachment 391624 [details] [diff] [review]
patch v3
[Checkin: Comment 5]


http://hg.mozilla.org/comm-central/rev/5f194ee88991