507046 - browser_passwordmgrdlg.js test intermittent failure

Status: VERIFIED FIXED

(Toolkit :: Password Manager, defect)

Description

[Drew Willcoxon :adw]

A focus issue?

Linux mozilla-central test everythingelse on 2009/07/28 10:01:09  
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox-Unittest/1248800469.1248802504.10500.gz

TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/toolkit/components/passwordmgr/test/browser/browser_passwordmgrdlg.js | 4 logins should match 'pass' - Got 0, expected 4
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/toolkit/components/passwordmgr/test/browser/browser_passwordmgrdlg.js | 10 logins should match '' - Got 0, expected 10
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/toolkit/components/passwordmgr/test/browser/browser_passwordmgrdlg.js | 7 logins should match 'moz' - Got 0, expected 7
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/toolkit/components/passwordmgr/test/browser/browser_passwordmgrdlg.js | 7 logins should match 'mozi' - Got 0, expected 7
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/toolkit/components/passwordmgr/test/browser/browser_passwordmgrdlg.js | 7 logins should match 'mozil' - Got 0, expected 7
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/toolkit/components/passwordmgr/test/browser/browser_passwordmgrdlg.js | 7 logins should match 'mozill' - Got 0, expected 7
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/toolkit/components/passwordmgr/test/browser/browser_passwordmgrdlg.js | 7 logins should match 'mozilla' - Got 0, expected 7
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/toolkit/components/passwordmgr/test/browser/browser_passwordmgrdlg.js | 2 logins should match 'mozilla.com' - Got 0, expected 2
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/toolkit/components/passwordmgr/test/browser/browser_passwordmgrdlg.js | 4 logins should match 'user' - Got 0, expected 4
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/toolkit/components/passwordmgr/test/browser/browser_passwordmgrdlg.js | 1 logins should match 'user ' - Got 0, expected 1
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/toolkit/components/passwordmgr/test/browser/browser_passwordmgrdlg.js | 2 logins should match ' user' - Got 0, expected 2
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/toolkit/components/passwordmgr/test/browser/browser_passwordmgrdlg.js | 10 logins should match 'http' - Got 0, expected 10
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/toolkit/components/passwordmgr/test/browser/browser_passwordmgrdlg.js | 1 logins should match 'https' - Got 0, expected 1
TEST-UNEXPECTED-FAIL | chrome://mochikit/content/browser/toolkit/components/passwordmgr/test/browser/browser_passwordmgrdlg.js | 2 logins should match 'secret' - Got 0, expected 2

Comment 1

[(no longer active)]

The problem here is bug 495751.  As a solution, we need to simulate the command event for the text box in another way (instead of synthesizing VK_RETURN).  Instead of calling win._filterPasswords directly as I did in bug 451352, I just dispatch a "command" event manually.

Patch forthcoming.

Comment 2

[(no longer active)]

Attachment: Patch (v1)

Comment 3

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/d8fa19464495

Comment 4

[(no longer active)]

Another point about this test which just occurred to me.  I implemented this as a browser chrome test mainly because it was most straightforward to do so, but does that mean that other Mozilla-based apps like Thunderbird and SeaMonkey don't get to run it?  If that is the case, I need to convert this to a mochitest...

Comment 5

[Robert Kaiser]

SeaMonkey runs browser chrome tests if they aren't in some directory only Firefox is building, but Thunderbird can't run any mochitest-based test as it's not a browser.

Comment 6

[[e-mail]]

Comment on attachment 392904 [details] [diff] [review]
Patch (v1)

>+                // dispatch the command event to the filter textbox
>+                let event = doc.createEvent("Events");
>+                event.initEvent("command", true, true);
>+                filter.dispatchEvent(event);
filter.doCommand();
[Implemented 8 years ago, so no excuse.]

Comment 7

[(no longer active)]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/8be4f76e4b82

Comment 8

[(no longer active)]

(In reply to comment #6)
> (From update of attachment 392904 [details] [diff] [review])
> >+                // dispatch the command event to the filter textbox
> >+                let event = doc.createEvent("Events");
> >+                event.initEvent("command", true, true);
> >+                filter.dispatchEvent(event);
> filter.doCommand();
> [Implemented 8 years ago, so no excuse.]

-> bug 510780.

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

Seems that the test works fine on 1.9.2 and 1.9.1. Marking as verified.