Closed Bug 507058 Opened 11 years ago Closed 11 years ago

nsNavBookmarks::GetBookmarkIdsForURITArray binds to a bogus index

Categories

(Toolkit :: Places, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9.2a1
Tracking Status
status1.9.2 --- beta1-fixed

People

(Reporter: sdwilsh, Assigned: mak)

References

Details

Attachments

(1 file)

We have this line of code:
mDBFindURIBookmarks->BindInt32Parameter(1, TYPE_BOOKMARK);
however, mDBFindURIBookmarks has only one parameter at index zero.  We should really fix that, and get a unit test for it.

I'm seeing this in startup, when we call PU_getMostRecentBookmarkForURI.
Flags: blocking1.9.2?
argh, thank you for catching this
Assignee: nobody → mak77
Blocks: 482346
Status: NEW → ASSIGNED
this does not affect 1.9.1
getting a specific unit test would be hard, there is no error check on that line, so the error is simply ignored and the method works correctly, even now. It's just a spurious call, not even sure it should block since the method works and is tested through getBookmarkIdsForURI.
Oh - awesome.  I just noticed that I was getting an NS_ENSURE_TRUE failure in my console with some of my storage patches applied.
Attached patch patch v1.0Splinter Review
Attachment #391547 - Flags: review?(sdwilsh)
Attachment #391547 - Flags: review?(sdwilsh) → review+
Comment on attachment 391547 [details] [diff] [review]
patch v1.0

r=sdwilsh
http://hg.mozilla.org/mozilla-central/rev/cde5a55da267
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
Flags: blocking1.9.2? → blocking1.9.2+
You need to log in before you can comment on or make changes to this bug.