Closed Bug 507058 Opened 11 years ago Closed 11 years ago
Nav Bookmarks::Get Bookmark Ids For URITArray binds to a bogus index
We have this line of code: mDBFindURIBookmarks->BindInt32Parameter(1, TYPE_BOOKMARK); however, mDBFindURIBookmarks has only one parameter at index zero. We should really fix that, and get a unit test for it. I'm seeing this in startup, when we call PU_getMostRecentBookmarkForURI.
argh, thank you for catching this
Assignee: nobody → mak77
Status: NEW → ASSIGNED
this does not affect 1.9.1
getting a specific unit test would be hard, there is no error check on that line, so the error is simply ignored and the method works correctly, even now. It's just a spurious call, not even sure it should block since the method works and is tested through getBookmarkIdsForURI.
Oh - awesome. I just noticed that I was getting an NS_ENSURE_TRUE failure in my console with some of my storage patches applied.
Attachment #391547 - Flags: review?(sdwilsh) → review+
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
You need to log in before you can comment on or make changes to this bug.