507058 - nsNavBookmarks::GetBookmarkIdsForURITArray binds to a bogus index

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Description

[Shawn Wilsher :sdwilsh]

We have this line of code:
mDBFindURIBookmarks->BindInt32Parameter(1, TYPE_BOOKMARK);
however, mDBFindURIBookmarks has only one parameter at index zero.  We should really fix that, and get a unit test for it.

I'm seeing this in startup, when we call PU_getMostRecentBookmarkForURI.

Comment 1

[Marco Bonardo [:mak]]

argh, thank you for catching this

Comment 2

[Marco Bonardo [:mak]]

this does not affect 1.9.1

Comment 3

[Marco Bonardo [:mak]]

getting a specific unit test would be hard, there is no error check on that line, so the error is simply ignored and the method works correctly, even now. It's just a spurious call, not even sure it should block since the method works and is tested through getBookmarkIdsForURI.

Comment 4

[Shawn Wilsher :sdwilsh]

Oh - awesome.  I just noticed that I was getting an NS_ENSURE_TRUE failure in my console with some of my storage patches applied.

Comment 5

[Marco Bonardo [:mak]]

Attachment: patch v1.0

Comment 6

[Shawn Wilsher :sdwilsh]

Comment on attachment 391547 [details] [diff] [review]
patch v1.0

r=sdwilsh

Comment 7

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/cde5a55da267