Last Comment Bug 507073 - Don't build nsBrowserDirectoryProvider as a separate library
: Don't build nsBrowserDirectoryProvider as a separate library
Status: RESOLVED FIXED
[ts]
: perf
Product: Firefox
Classification: Client Software
Component: General (show other bugs)
: Trunk
: All All
P3 normal (vote)
: Firefox 3.7a1
Assigned To: Ryan Flint [:rflint] (ping via IRC for reviews)
:
:
Mentors:
Depends on: 698586
Blocks:
  Show dependency treegraph
 
Reported: 2009-07-28 19:07 PDT by Ryan Flint [:rflint] (ping via IRC for reviews)
Modified: 2011-10-31 14:23 PDT (History)
5 users (show)
rflint: in‑testsuite+
rflint: in‑litmus-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
WIP (14.38 KB, patch)
2009-07-28 19:07 PDT, Ryan Flint [:rflint] (ping via IRC for reviews)
no flags Details | Diff | Splinter Review
Patch (26.92 KB, patch)
2009-11-06 15:17 PST, Ryan Flint [:rflint] (ping via IRC for reviews)
vladimir: review+
Details | Diff | Splinter Review

Description User image Ryan Flint [:rflint] (ping via IRC for reviews) 2009-07-28 19:07:41 PDT
Created attachment 391261 [details] [diff] [review]
WIP
Comment 1 User image Dietrich Ayala (:dietrich) 2009-10-14 15:46:21 PDT
what else is left to do here?
Comment 2 User image Ryan Flint [:rflint] (ping via IRC for reviews) 2009-11-06 15:17:46 PST
Created attachment 410881 [details] [diff] [review]
Patch
Comment 3 User image :Gavin Sharp [email: gavin@gavinsharp.com] 2009-11-06 15:21:12 PST
What's the rationale here? Seems pretty unlikely to matter much given that we ship libxul.
Comment 4 User image :Gavin Sharp [email: gavin@gavinsharp.com] 2009-11-06 15:52:16 PST
Ryan rightfully points out that neither of these are linked into libxul, so that comment doesn't make any sense!
Comment 5 User image Vladimir Vukicevic [:vlad] [:vladv] 2009-11-06 17:01:21 PST
Comment on attachment 410881 [details] [diff] [review]
Patch

Looks good to me!
Comment 6 User image Ryan Flint [:rflint] (ping via IRC for reviews) 2009-11-06 23:23:46 PST
http://hg.mozilla.org/mozilla-central/rev/e91b5f834338

Note You need to log in before you can comment on or make changes to this bug.