507139 - MetaData Properties window doesn't respect locale for file size and image dimensions

Status: NEW

(Firefox :: Page Info Window, defect)

Description

[Philip Chee]

Spinning off the Firefox part into a separate bug.
=============================================================

+++ This bug was initially created as a clone of Bug #252043 +++

Page Info shows incorrect size, not honouring locale settings. 

I want to notice that many European countries use commas (not periods) as a decimal separator. 

This must be fixed in Mozilla App Suite and Mozilla Firefox.

=============================================================

In Bug 252043, I updated the Suite part of the existing patch and the bug is now fixed in SeaMonkey. But the patch was against CVS and also contains the Firefox part. See attachment 388925 [details] [diff] [review]. Somebody needs to do the same for Firefox.

Comment 1

[Tanner M. Young [:tmyoung]]

Philip: Are you planning on doing this?  (I am happy to port the patch and work with things--this will be a lot easier since metaData.js was removed, but I am not entirely sure how to test it.)

Comment 2

[Philip Chee]

> Philip: Are you planning on doing this?  (I am happy to port the patch and work

Sorry, no. I'm just triaging and fixing SeaMonkey Page Info bugs.

> with things--this will be a lot easier since metaData.js was removed, but I am
> not entirely sure how to test it.)

Switch to a locale/langpack (e.g. de) where the comma is used as the decimal point and a space or period is used as the thousands separator.

Comment 3

[Tanner M. Young [:tmyoung]]

Assigning to me.  I have already made the changes from the patch, and now I just need to test them.

Comment 4

[Axel Hecht [:Pike]]

I'm not convinced the SeaMonkey patch is right, asked KaiRo over there.

To copy the comment, toLocaleString() uses the OS locale, not the gecko locale, and thus there might be a mismatch. It depends much on context which one is considered more right if the two don't match.

In this particular case, I'm somewhat leaning towards gecko locale, but I'll wait on comments on bug 252043.

Comment 5

[Tanner M. Young [:tmyoung]]

Since we want gecko-locale based number formatting (which I am totally in favor of), I will wait on Bug 542502 before I move on this.

Comment 6

[Tanner M. Young [:tmyoung]]

I will not have time to do this in the foreseeable future, regardless of what happens on Bug 542502, so I will unassign myself from this bug, in case someone else can work on it before I would be able to.