507170 - Removing calendar breaks unifinder [Error: "filter is not defined" in calendar-unifinder.js]

Status: VERIFIED FIXED

(Calendar :: General, defect)

Description

[Stefan Sitter [:ssitter]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.2pre) Gecko/20090729 Calendar/1.0pre (BuildID: 20090729050908)

Steps to Reproduce:
===================
1. Start with new profile
2. Create a second calendar
3. Create events in both calendars and check their display in the unifinder
4. Delete one of the calendars

Actual Results:
===============
Unifinder still shows the events from both calendars.

Expected Results:
=================
Unifinder shows only the events from the remaining calendar.

Additional Information:
=======================

Another regression from Bug 500718. Error Console shows:

Error: [Exception... "'[JavaScript Error: "filter is not defined" {file: "chrome://calendar/content/calendar-unifinder.js" line: 955}]' when calling method: [calICompositeObserver::onCalendarRemoved]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: file:///E:/sunbird/calendar-js/calUtils.js :: notifyFunc :: line 1221"  data: yes] 
STACK: 
1: [file:///E:/sunbird/calendar-js/calUtils.js:1224] notifyFunc
2: [file:///E:/sunbird/calendar-js/calUtils.js:1227] calListenerBag_notify
3: [file:///E:/sunbird/components/calCompositeCalendar.js:227] cCC_removeCalendar
4: [null:0] null
5: [chrome://calendar/content/widgets/calendar-list-tree.xml:538] removeCalendar
6: [chrome://calendar/content/widgets/calendar-list-tree.xml:114] cMO_onCalendarUnregistering
7: [null:0] null
8: [file:///E:/sunbird/calendar-js/calUtils.js:1221] notifyFunc
9: [file:///E:/sunbird/calendar-js/calUtils.js:1227] calListenerBag_notify
10: [file:///E:/sunbird/calendar-js/calCalendarManager.js:598] anonymous

Source File: file:///E:/sunbird/calendar-js/calUtils.js Line: 1224

Comment 1

[Philipp Kewisch [:Fallen][☁️📆]]

Taking, I have a patch for this i will upload later on.

Comment 2

[Philipp Kewisch [:Fallen][☁️📆]]

Attachment: Fix - v1

Comment 3

[Stefan Sitter [:ssitter]]

Comment on attachment 391836 [details] [diff] [review]
Fix - v1

r=ssitter

Note: during testing I sometimes noticed the following in console when removing the calendar:

###!!! ASSERTION: row count did not change by the amount suggested, check caller: 'rowCount == mRowCount', file e:/dev/comm-central/src/mozilla/layout/xul/base/src/tree/src/nsTreeBodyFrame.cpp, line 1917

WARNING: row count changed unexpectedly: 'mRowCount == rowCount', file e:/dev/comm-central/src/mozilla/layout/xul/base/src/tree/src/nsTreeBodyFrame.cpp, line 2871

Maybe someone knows what to do with this ...

Comment 4

[Philipp Kewisch [:Fallen][☁️📆]]

Sounds to me like we are passing the wrong numbers when calling the onRowCountChanged() function in the calendar tree. I've filed bug 508041 to investigate.


Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/34c24722b6d1>

-> FIXED

Comment 5

[Damian Szczepanik]

verified with
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.9pre) Gecko/20100313 Calendar/1.0b2pre

Comment 6

[Philipp Kewisch [:Fallen][☁️📆]]

These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".