507260 - resizing planet page very slow on trunk

Status: RESOLVED FIXED

(Core :: Layout, defect, P2)

Description

[Robert Sayre]

looks like it's due to a performance problem re-breaking the text of the articles. Compared to Fx 3.5 or Safari 4, it's quite bad.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Is this a regression?  Do we have a regression range?

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

And from comment 0, it sounds like you have profile data.  Care to share it?

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I wonder if this is related to interruptible reflow.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

See if the problem goes away with
export GECKO_REFLOW_INTERRUPT_CHECKS_TO_SKIP=1000000000

Comment 5

[Boris Zbarsky [:bzbarsky]]

As I recall, the claim was yes.  I just haven't gotten time to debug yet...

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(In reply to comment #4)
> See if the problem goes away with
> export GECKO_REFLOW_INTERRUPT_CHECKS_TO_SKIP=1000000000

It does.  I just tested on the 2009-08-10-04-mozilla-central Linux x86_64 nightly.

Comment 7

[Mike Shaver (:shaver emeritus)]

I see this on Win7 using today's 3.6 build, and I get multiple-second lockups (5+ seconds) when trying to resize with this bug's URL or http://www.psy.fsu.edu/~baumeistertice/goodaboutmen.htm in a foreground tab.  If I resize with those pages in a background tab, switching to the troublesome document appears to reflow almost instantly.

Comment 8

[Mike Shaver (:shaver emeritus)]

More detail: if I am resizing from a narrowish window to a wide one on my Win7 machine, it "locks" the entire Windows UI for 15+ seconds, and task manager shows Firefox as taking 13% CPU for the entire time, and staying at 13% for several seconds after control is restored.  (That's how my system says "one CPU fully used", I think because I have a quad core system with HT.)

When the Windows UI is locked up, I get the resize left-right cursor, and clicking on other applications does nothing. I don't get the wait cursor, nor the dimming out of the application. Task Manager continues to update, and video from another process (VLC) plays per usual.

I can try to get xperf working here if it's needed, since the effects seem to be much more pronounced on Windows than on Mac?

Comment 9

[Boris Zbarsky [:bzbarsky]]

On Windows, you're almost certainly seeing the effects from the nested event loop resizes entail.  See bug 496788 and bug 499447, say.

So I'd like to keep this bug focused on what's going on with Mac/Linux.

Comment 10

[Boris Zbarsky [:bzbarsky]]

The patch on bug 499447 fixes it for me on Mac. So it was really the same issue after all....

Comment 11

[Boris Zbarsky [:bzbarsky]]

Fixed by the checkin for bug 499447.

Comment 12

[Boris Zbarsky [:bzbarsky]]

Fixed on 1.9.2 as well.