507405 - make_incremental_updates.py throws superfluous error message for all Mac builds

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[[e-mail] (:bhearsum)]

It talks about not being able to get the buildid, which is because of a broken regex in decode_filename for the previous release. It happened in 3.5.2, 3.0.12, and probably further back than that. Not super high priority, but it's a scary message to find.

Comment 1

[Chris Cooper [:coop] (he/him)]

Attachment: Fix filename parsing to handle two- and three-part version strings; m-c, NPOTB

The version was getting poorly parsed so we were ending up with the locale string munged into the platform, e.g. 'en-US.mac'. Consequently, we were never hitting the mac-specific code for finding application.ini.

The change to the regexp will work for two-part version strings (e.g. 3.6b2) or 3-part version strings (e.g. 3.5.4).

bhearsum: how many branches will we need to land this on? I know it's NPOTB, but I want to get those patches ready too, if necessary. Not sure whether we pull tip for the update code or not.

Comment 2

[[e-mail] (:bhearsum)]

Comment on attachment 396463 [details] [diff] [review]
Fix filename parsing to handle two- and three-part version strings; m-c, NPOTB

This seems fine. We could due with support for 4 part filenames, too, like Tb2.0.0.x has but it's up to you.

Comment 3

[Chris Cooper [:coop] (he/him)]

Comment on attachment 396463 [details] [diff] [review]
Fix filename parsing to handle two- and three-part version strings; m-c, NPOTB

Added the fix for 4-part version strings.

http://hg.mozilla.org/mozilla-central/rev/fa3035da4e36

Comment 4

[Chris Cooper [:coop] (he/him)]

Comment on attachment 396463 [details] [diff] [review]
Fix filename parsing to handle two- and three-part version strings; m-c, NPOTB

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/26d790a1fb5e

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/198a40c8966c

CVS Trunk:
Checking in make_incremental_updates.py;
/cvsroot/mozilla/tools/update-packaging/make_incremental_updates.py,v  <--  make_incremental_updates.py
new revision: 1.11; previous revision: 1.10
done

Comment 5

[Nick Thomas [:nthomas] (UTC+12)]

This got picked up as part of UPDATE_PACKAGING_R10 in bug 514305.