507509 - [IE 7] New home/start page needs CSS lovin' in IE 7 (layout problems)

Status: VERIFIED FIXED

(support.mozilla.org :: General, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot

The new SUMO home page/start page needs some CSS lovin' in IE 7.

See screenshot, attached.

Comment 1

[Paul Craciunoiu [:paulc]]

How does it look in IE 6 and 8?

Comment 2

[Paul Craciunoiu [:paulc]]

Also Chrome and Opera would be nice to check :)

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot of IE 6

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

IE 8, Safari 4 and Opera 9.64 display fine, so I guess we can use this bug for IE 6/7 issues, if you're happy with that, Paul?

Comment 5

[Paul Craciunoiu [:paulc]]

Yeah. Thanks Stephen! It looks like fixing IE6 hits the sweet spot for IE7 too.
Great that the others are fine!

Comment 6

[Paul Craciunoiu [:paulc]]

Attachment: patch, v1

This at least does it for IE6. I've tried the "See all" button for IE7 too, but couldn't really test.

Comment 7

[Paul Craciunoiu [:paulc]]

Comment on attachment 391820 [details] [diff] [review]
patch, v1

Gah. I missed the sidebar "Ways to get help" fix.
I'll post a patch later.

Comment 8

[Paul Craciunoiu [:paulc]]

Attachment: IE6 patch, v1

This should do it for IE6. Might need a screenshot of IE7 to see what's left to fix there.

I created .gif's to help with the transparency. They're not great, but they'll do -- it would look much better than with that grey-ish stuff anyway. I'll attach the gifs after this.

Comment 9

[Paul Craciunoiu [:paulc]]

Attachment: gifs.tar.gz

Comment 10

[Paul Craciunoiu [:paulc]]

Comment on attachment 391923 [details] [diff] [review]
IE6 patch, v1

Just going through my r? list

Comment 11

[Paul Craciunoiu [:paulc]]

Attachment: v2

This should take care of all the issues. Tested this on IE6/7/8, Chrome 3, Opera 10, Fx 3.5.3 (all WinXP) and Fx3.5.3 on Ubuntu Linux.

For IE6, you need to place the attached gifs from this bug into webroot/styles/mozms2, since it doesn't support png transparency.

Comment 12

[Paul Craciunoiu [:paulc]]

Sorry to add to 1.4.2, but it would be really nice to make this usable for IE too, since it's the home page.

Comment 13

[James Socol [:jsocol, :james]]

Comment on attachment 406552 [details] [diff] [review]
v2

This patch works for me in:
IE6/7/8
Chrome
Opera
Firefox 3.5 on Windows/Mac

Except, the file "sidebar-sumo.gif" looks awful. Terrible aliasing and almost impossible to read. So the CSS looks good, but please double check the images before committing.

Comment 14

[Paul Craciunoiu [:paulc]]

I'm pretty sure the images have always been like that. So we need someone to re-convert sidebar-sumo from the png version to a .gif

Comment 15

[James Socol [:jsocol, :james]]

CCing Neil, as he surely has access to better image editing programs than I (who basically has mspaint).

Comment 16

[Paul Craciunoiu [:paulc]]

Putting the list here to make sure I don't forget the images.
------
Sending        webroot/styles/mozms2/ie.css
Sending        webroot/styles/mozms2/ie7.css
Adding  (bin)  webroot/styles/mozms2/logo-ff.gif
Adding  (bin)  webroot/styles/mozms2/searchbar.gif
Adding  (bin)  webroot/styles/mozms2/sidebar-sumo.gif
Adding  (bin)  webroot/styles/mozms2/sidebar-ways.gif
Adding  (bin)  webroot/styles/mozms2/sidebar-wtgh.gif
Sending        webroot/styles/mozms2.css
Transmitting file data ........
------
r54607 (trunk)

Spinoff bug 525358.

https://support-stage.mozilla.org/en-US/kb/New+Home+Page

Comment 17

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using IE 6, 7, and 8 on https://support-stage.mozilla.org/en-US/kb/New+Home+Page (also tested with Chrome, Opera, Firefox 3.0, 3.5).

(Hopefully there's a separate bug covering the missing search terms.)

Comment 18

[Stephen Donner [:stephend] Not actively reading bugmail]

Nevermind me, that's covered in https://bugzilla.mozilla.org/show_bug.cgi?id=502029#c23

Comment 19

[Paul Craciunoiu [:paulc]]

r54677 (prod) and r54680 (fennec)

Comment 20

[Paul Craciunoiu [:paulc]]

Reopening per bug 535600 comment 5. Patch to follow.

Comment 21

[Paul Craciunoiu [:paulc]]

Attachment: fixes IE6 issue from attachment 419947

I didn't see any regressions after making this change.

Comment 22

[James Socol [:jsocol, :james]]

Comment on attachment 419965 [details] [diff] [review]
fixes IE6 issue from attachment 419947 [details]

Returns the "Ways to get help" box. Are we waiting on bug 525358 to make the background images not look like crap?

Comment 23

[Neil Lee [:neilio]]

James (whomever) - did you still need help with this? If so, what specifically needs to be done?

Comment 24

[James Socol [:jsocol, :james]]

Neil: see bug 525358. We just need less-awful-looking GIF versions of the PNGs for IE.

Comment 25

[Paul Craciunoiu [:paulc]]

(In reply to comment #22)
> (From update of attachment 419965 [details] [diff] [review])
> Returns the "Ways to get help" box. Are we waiting on bug 525358 to make the
> background images not look like crap?
Up to you. Let me know if you want me to commit or wait.

Comment 26

[James Socol [:jsocol, :james]]

Let's not wait, that box is there with our without this patch. Go ahead and commit.

Comment 27

[Paul Craciunoiu [:paulc]]

Done, r59238

Comment 28

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; tested with:

* IE 6, 7, 8
* Opera 10.10
* Safari 4.0.4 (heh)
* Google Chrome 3.0.195.38
* Firefox 3.5.7
* Firefox 3.6 beta 5

Comment 29

[James Socol [:jsocol, :james]]

Reopening to commit to branches/1.5.1_temp. Will re-resolve after patches are committed.

Comment 30

[James Socol [:jsocol, :james]]

On branch, r62422.

Comment 31

[Vishal Kamdar [:vish_moz]]

Verified, FIXED