white-space clean-up in ad_blocking.css

RESOLVED FIXED

Status

Camino Graveyard
Annoyance Blocking
--
minor
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: philippe (part-time), Assigned: philippe (part-time))

Tracking

({fixed1.8.1.23})

Trunk
x86
Mac OS X
fixed1.8.1.23

Details

(Whiteboard: [camino-2.0])

Attachments

(1 attachment, 1 obsolete attachment)

4.85 KB, patch
Smokey Ardisson (offline for a while; not following bugs - do not email)
: review+
Stuart Morgan
: superreview+
Details | Diff | Splinter Review
(Assignee)

Description

8 years ago
Created attachment 391771 [details] [diff] [review]
patch

Turn show hidden characters in the text editor, there is quite a bit of redundant white-space throughout the file, particularly around the 'mail.google.com' block.

There is also inconsistent use of '! important' vs '!important' -again a white-space issue. I made it consistent by removing the white-space between '!' and 'i' (!important occurs more often in the file).
Attachment #391771 - Flags: review?(alqahira)

Comment 1

8 years ago
As long as you are doing a big cleanup, could you add spaces after the opening brace of inline rule blocks (some have it already, but many are really cramped) and get rid of the inconsistent ;'s?

So:
 div[id="ad"] {display:block !important;}
->
 div[id="ad"] { display:block !important }
(Assignee)

Comment 2

8 years ago
(In reply to comment #1)
OK.
(Assignee)

Comment 3

8 years ago
Created attachment 391781 [details] [diff] [review]
patch - v2

with additional changes per comment 1
Assignee: nobody → phiw
Attachment #391771 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #391781 - Flags: review?(alqahira)
Attachment #391771 - Flags: review?(alqahira)

Comment 4

8 years ago
Comment on attachment 391781 [details] [diff] [review]
patch - v2

Awesome, thanks! This has sr=me :)
Attachment #391781 - Flags: superreview+
Comment on attachment 391781 [details] [diff] [review]
patch - v2

And r=me; thanks again for cleaning up after all that whitespace insanity!
Attachment #391781 - Flags: review?(alqahira) → review+
Landed on cvs trunk and the CAMINO_2_0_BRANCH.

We'll want to take this on the 1_8 branch in the first release where we've taken both bug 485865 and bug 502536, which may be 1.6.9 or may be subsequent to that, in order to keep the files in sync.
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Flags: camino1.6.9?
Resolution: --- → FIXED
Whiteboard: [camino-2.0]
Fixed for 1.6.9 by the rollup patch on bug 502536.
Keywords: fixed1.8.1.23
Flags: camino1.6.9? → camino1.6.9+
You need to log in before you can comment on or make changes to this bug.