Stop running build-and-unittest jobs

RESOLVED FIXED

Status

Release Engineering
General
P2
normal
RESOLVED FIXED
8 years ago
4 years ago

People

(Reporter: joduinn, Assigned: catlee)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(5 attachments, 1 obsolete attachment)

There are dep. bugs tracking getting unittests running properly on debug builds, separate from the builds. Once that is running with similar results, we can stop running our current all-in-one build-and-unittest jobs.

This is important to reduce per-push load on our infrastructure.
(Assignee)

Comment 1

8 years ago
Something we could do in the short term is disable the tests portion of the current unittest build.  So we'd do the unittest build, and then hand off the build to the 'mochitests' and 'everythingelse' builders.
(In reply to comment #1)
> Something we could do in the short term is disable the tests portion of the
> current unittest build.  So we'd do the unittest build, and then hand off the
> build to the 'mochitests' and 'everythingelse' builders.

IIRC, ted said that 'make check' isn't packaged currently and would have to stay with the builder. Only takes a couple of minutes to run though.
Futuring till blocking bug is fixed.
Component: Release Engineering → Release Engineering: Future
(Assignee)

Updated

8 years ago
Assignee: nobody → catlee
Component: Release Engineering: Future → Release Engineering
(Assignee)

Comment 4

8 years ago
Created attachment 401025 [details] [diff] [review]
Stop running tests in unittest builder

This is phase 1 of this bug - turning off most of the tests that are run as part of the current unittest build+tests builder.  Once we have unittests on debug and optimized builds running, we can stop running this builder entirely.
Attachment #401025 - Flags: review?(bhearsum)
(Assignee)

Updated

8 years ago
Depends on: 516983
(Assignee)

Updated

8 years ago
Priority: -- → P2
Comment on attachment 401025 [details] [diff] [review]
Stop running tests in unittest builder

yay!
Attachment #401025 - Flags: review?(bhearsum) → review+
(Assignee)

Comment 6

8 years ago
Comment on attachment 401025 [details] [diff] [review]
Stop running tests in unittest builder

changeset:   416:3968af736cff
Attachment #401025 - Flags: checked-in+
(Assignee)

Comment 7

8 years ago
Looks good
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
(Assignee)

Comment 8

8 years ago
Actually, reopening this.  Phase 2 is to shut of the unittest builds altogether, but we need to wait until problems with optimized tests and debug tests are ironed out.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Updated

8 years ago
Depends on: 523385
(Assignee)

Updated

8 years ago
Depends on: 524775
(Assignee)

Comment 9

8 years ago
Created attachment 410234 [details] [diff] [review]
Allow unittests to be toggled on per-platform basis
Attachment #410234 - Flags: review?(bhearsum)
(Assignee)

Comment 10

8 years ago
Created attachment 410235 [details] [diff] [review]
buildbot-configs to turn off unittests on linux mozilla-central
Attachment #410235 - Flags: review?(bhearsum)
Attachment #410234 - Flags: review?(bhearsum) → review+
Comment on attachment 410234 [details] [diff] [review]
Allow unittests to be toggled on per-platform basis

>@@ -4255,22 +4255,23 @@ class WinmoBuildFactory(MobileBuildFacto
>             haltOnFailure=True
>         )
> 
> class UnittestPackagedBuildFactory(MozillaBuildFactory):
>     def __init__(self, platform, test_suites, env=None,
>             mochitest_leak_threshold=None, crashtest_leak_threshold=None,
>             totalChunks=None, thisChunk=None, chunkByDir=None,
>             **kwargs):
>+        self.platform = platform.split('-')[0]
>+
>         if env is None:
>-            self.env = MozillaEnvironments['%s-unittest' % platform].copy()
>+            self.env = MozillaEnvironments['%s-unittest' % self.platform].copy()
>         else:
>             self.env = env


This hunk is going to conflict with one of the patches in bug 515436. Should be easy enough to merge, just a heads up though!

Looks good otherwise.
Comment on attachment 410235 [details] [diff] [review]
buildbot-configs to turn off unittests on linux mozilla-central

yay
Attachment #410235 - Flags: review?(bhearsum) → review+
(Assignee)

Comment 13

8 years ago
Comment on attachment 410234 [details] [diff] [review]
Allow unittests to be toggled on per-platform basis

changeset:   478:3927145d3dbe
Attachment #410234 - Flags: checked-in+
(Assignee)

Comment 14

8 years ago
Comment on attachment 410235 [details] [diff] [review]
buildbot-configs to turn off unittests on linux mozilla-central

changeset:   1696:55e9f1f70d15
Attachment #410235 - Flags: checked-in+
Comment on attachment 410234 [details] [diff] [review]
Allow unittests to be toggled on per-platform basis

The builder names changed with this patch, eg from
  OS X 10.5.2 mozilla-central test debug mochitests-1/5
to
  OS X 10.5.2 mozilla-central debug test mochitests-1/5
Same for opt. Caused some confusion.
sdwilsh told me today that he believes we're ready to turn off refcnt builds on m-c Windows.

Dbaron, you've heavily informed here, can you confirm that?,
(In reply to comment #16)
> sdwilsh told me today that he believes we're ready to turn off refcnt builds on
> m-c Windows.
> 
> Dbaron, you've heavily informed here, can you confirm that?,

Yes.  Sounds fine to me.
(Assignee)

Comment 18

8 years ago
Created attachment 415996 [details] [diff] [review]
buildbot-configs to turn off unittests on win32 mozilla-central

woot!
Attachment #415996 - Flags: review?(bhearsum)
(Assignee)

Comment 19

8 years ago
How about project branches?  Can we turn off Linux and Windows unittest builds on tracemonkey, places and/or electrolysis?
We'd have to turn on opt and debug test there first, right ?
Attachment #415996 - Flags: review?(bhearsum) → review+
(Assignee)

Comment 21

8 years ago
Comment on attachment 415996 [details] [diff] [review]
buildbot-configs to turn off unittests on win32 mozilla-central

changeset:   1833:0c379ff0c821
Attachment #415996 - Flags: checked-in+
(Assignee)

Comment 22

8 years ago
Created attachment 421861 [details] [diff] [review]
turn off unittests on osx mozilla-central

dbaron: please r+ when we're ready to shut off the logrefcnt builds on osx on trunk
Attachment #421861 - Flags: review?(dbaron)
Attachment #421861 - Flags: review?(ccooper)
Attachment #421861 - Flags: review?(ccooper) → review+
Comment on attachment 421861 [details] [diff] [review]
turn off unittests on osx mozilla-central

I'm ok with turning them off now.

We probably want to do the same for TraceMonkey.
Attachment #421861 - Flags: review?(dbaron) → review+
(Assignee)

Comment 24

8 years ago
Created attachment 421880 [details] [diff] [review]
turn off unittests on osx mozilla-central and tracemonkey

disable on tracemonkey too
Attachment #421861 - Attachment is obsolete: true
Attachment #421880 - Flags: review?(ccooper)
Attachment #421880 - Flags: review?(ccooper) → review+
(Assignee)

Comment 25

8 years ago
Comment on attachment 421880 [details] [diff] [review]
turn off unittests on osx mozilla-central and tracemonkey

changeset:   1951:c5e38ec5870d
Attachment #421880 - Flags: checked-in+
(Assignee)

Updated

8 years ago
Status: REOPENED → RESOLVED
Last Resolved: 8 years ago8 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.