507555 - wrong accessible is created for HTML:li with float and "display: inline" style

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[alexander :surkov (:asurkov)]

Attachment: testcase

Investigate attached testcase in DOMi or accProble, HTML:li accessible are exposed with paragraph role, obviously we use nsHyperTextAccessible for them instead of nsHTMLLIAccessible.

Comment 1

[alexander :surkov (:asurkov)]

More precisely "display: inline; float: left" on HTML:li makes it paragraph accessible.

Comment 2

[alexander :surkov (:asurkov)]

It sounds like regression from bug 346730. This html:li's frame has blockFrame type and hasn't mBullet that's the reason why CreateHTMLAccessibleByMarkup and nsBlockFrame::GetAccessible (http://mxr.mozilla.org/mozilla-central/source/layout/generic/nsBlockFrame.cpp#6339) fails to create nsHTMLLiAccessible.

Comment 3

[Hubert Figuiere [:hub]]

Attachment: real test case

comment #1 say that is becomes "role paragraph" with the CSS "float: right"

Updating the html test case to actually do that and exhibit the problem.

Comment 4

[alexander :surkov (:asurkov)]

Attachment: patch

create list item accessible for HTML:li unconditionally. If HTML:li gets a block display style (i.e. nsBlockFrame is used) then we didn't create list item accessible. We were needed the nsBlockFrame to create list item accessible because it knew about the bullet, nowadays list item accessible knows about bullet itself, so we can create list item accessible by tag name on a11y side.

We still need nsBlockFrame to create an accessible for elements different than HTML:li but styled as display:list-item.

Comment 5

[Trevor Saunders (:tbsaunde)]

Comment on attachment 658398 [details] [diff] [review]
patch

>+  if (tag == nsGkAtoms::dt || tag == nsGkAtoms::li) {
>+    // Create list item accessible unconditionally by tag name. For elements
>+    // styled as list item the nsBlockFrame takes care.

nit, ending with "takes care" is weird english.

Comment 6

[alexander :surkov (:asurkov)]

(In reply to Trevor Saunders (:tbsaunde) from comment #5)
> Comment on attachment 658398 [details] [diff] [review]
> patch
> 
> >+  if (tag == nsGkAtoms::dt || tag == nsGkAtoms::li) {
> >+    // Create list item accessible unconditionally by tag name. For elements
> >+    // styled as list item the nsBlockFrame takes care.
> 
> nit, ending with "takes care" is weird english.

Trev, please suggest options at least for comments concerning english. "takes care" -> "works"?

Comment 7

[Trevor Saunders (:tbsaunde)]

(In reply to alexander :surkov from comment #6)
> (In reply to Trevor Saunders (:tbsaunde) from comment #5)
> > Comment on attachment 658398 [details] [diff] [review]
> > patch
> > 
> > >+  if (tag == nsGkAtoms::dt || tag == nsGkAtoms::li) {
> > >+    // Create list item accessible unconditionally by tag name. For elements
> > >+    // styled as list item the nsBlockFrame takes care.
> > 
> > nit, ending with "takes care" is weird english.
> 
> Trev, please suggest options at least for comments concerning english.
> "takes care" -> "works"?

sorry, how about "nsBlockFrame creates the list item accessible for other elements styled as list items"?

or may be replace "takes care" by "does this"

Comment 8

[alexander :surkov (:asurkov)]

(In reply to Trevor Saunders (:tbsaunde) from comment #7)

> sorry, how about "nsBlockFrame creates the list item accessible for other
> elements styled as list items"?

ok, thank you

Comment 9

[alexander :surkov (:asurkov)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/33a59f79700f

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/33a59f79700f