Last Comment Bug 507621 - output element doesn't show external images
: output element doesn't show external images
Status: RESOLVED WONTFIX
:
Product: Core Graveyard
Classification: Graveyard
Component: XForms (show other bugs)
: unspecified
: x86 Windows XP
: -- minor (vote)
: ---
Assigned To: Philipp Wagner [:imphil]
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2009-07-31 05:52 PDT by Tangui LE PENSE
Modified: 2016-07-15 14:46 PDT (History)
3 users (show)
See Also:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
XForms output element and external image (534 bytes, application/xhtml+xml)
2009-07-31 05:53 PDT, Tangui LE PENSE
no flags Details
make non-bound xf:output with images work (2.15 KB, patch)
2009-07-31 09:02 PDT, Philipp Wagner [:imphil]
no flags Details | Diff | Splinter Review
v2 (1.95 KB, patch)
2009-07-31 09:15 PDT, Philipp Wagner [:imphil]
surkov.alexander: review+
aaronr: review+
Details | Diff | Splinter Review

Description Tangui LE PENSE 2009-07-31 05:52:34 PDT
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; fr; rv:1.9.1.1) Gecko/20090715 Firefox/3.5.1 (.NET CLR 3.5.30729)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; fr; rv:1.9.1.1) Gecko/20090715 Firefox/3.5.1 (.NET CLR 3.5.30729)

Using the output element with mediatype attribute set as 'image/png' and an appropriate value for the value attribute doesn't work.

Reproducible: Always

Actual Results:  
Nothing is displayed

Expected Results:  
An image should be displayed

It is an very useful feature for generating charts (with Google charts) on the fly.
Comment 1 Tangui LE PENSE 2009-07-31 05:53:28 PDT
Created attachment 391860 [details]
XForms output element and external image
Comment 2 Philipp Wagner [:imphil] 2009-07-31 09:02:41 PDT
Created attachment 391890 [details] [diff] [review]
make non-bound xf:output with images work

When doing no bind, @typelist is not set. This causes the image not to be displayed. This patch assumes that, if the node is not bound, a URL is given in @value and displays it.
Comment 3 alexander :surkov 2009-07-31 09:10:05 PDT
Comment on attachment 391890 [details] [diff] [review]
make non-bound xf:output with images work

 
>   /* output mediatype="image/*" */
>+html|*:root output[mozType|mediatype^="image"] {
>+  -moz-binding: url('chrome://xforms/content/xforms-xhtml.xml#xformswidget-output-mediatype-anyURI');
>+}
> html|*:root output[mozType|typelist~="http://www.w3.org/2001/XMLSchema#anyURI"][mozType|mediatype^="image"] {
>   -moz-binding: url('chrome://xforms/content/xforms-xhtml.xml#xformswidget-output-mediatype-anyURI');
> }

might be worth to change the line above instead otherwise it's not needed.
Comment 4 Philipp Wagner [:imphil] 2009-07-31 09:15:53 PDT
Created attachment 391892 [details] [diff] [review]
v2

remove unnecessary CSS rule.
Comment 5 alexander :surkov 2009-07-31 09:23:10 PDT
Comment on attachment 391892 [details] [diff] [review]
v2

r=me
Comment 6 aaronr 2009-08-10 16:24:27 PDT
Comment on attachment 391892 [details] [diff] [review]
v2

I was hesitant about this variation on using @value, but as Philipp pointed out to me, it is already supported by Orbeon (http://www.orbeon.com/ops/doc/reference-xforms-guide#xforms-relative-paths-image-mediatype).  And it does make sense.

I've asked Philipp to follow up with the W3C to see if this Orbeon behavior (treating @value as anyURI if @mediatype present) is specific to images or if any mediatype value is provided.
Comment 7 aaronr 2009-08-10 16:38:39 PDT
checked into FF3 (cvs trunk)
Comment 8 Philipp Wagner [:imphil] 2009-08-13 10:33:02 PDT
discussion is at http://lists.w3.org/Archives/Public/www-forms/2009Aug/0021.html
Comment 9 alexander :surkov 2009-08-26 21:04:22 PDT
(In reply to comment #8)
> discussion is at
> http://lists.w3.org/Archives/Public/www-forms/2009Aug/0021.html

What is result of discussion? Should I put the patch to mercurial?
Comment 10 aaronr 2009-08-27 10:10:27 PDT
I thought the result was that we would back out this patch from cvs.  Philipp, do you agree?
Comment 11 Philipp Wagner [:imphil] 2009-08-30 15:25:19 PDT
Yes, the WG does not seem to have really decided what to do with that syntax and thus it's probably best to back it out to avoid that people rely on that extension.
Comment 12 Philipp Wagner [:imphil] 2010-02-27 15:13:59 PST
This bug never made it into hg trunk and the XForms WG seems to discourage this usage, so let's close it.

Note You need to log in before you can comment on or make changes to this bug.