initializeSanitizer() can fail because "gPrefService.getBranch is not a function"

RESOLVED FIXED in Firefox 3.7a1

Status

()

--
major
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: dao, Assigned: dao)

Tracking

({verified1.9.2})

Trunk
Firefox 3.7a1
verified1.9.2
Points:
---
Bug Flags:
blocking-firefox3.6 +

Firefox Tracking Flags

(status1.9.2 beta1-fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
> JavaScript error: chrome://browser/content/browser.js, line 1476: gPrefService.getBranch is not a function
> http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1249040192.1249041497.16783.gz

If initializeSanitizer() fails, anything that comes after it in delayedStartup() won't be executed. Attachment 391667 [details] [diff] would fix this.
Flags: blocking-firefox3.6?
What's the effect of this on users / testers / us? Need to know that in order to make a blocking decision.
Flags: blocking-firefox3.6? → blocking-firefox3.6+
Johnath filled me in on how not getting to delayedStartup() would be bad, which I see now.

Dao: can you take, since you've got a fix for this in a patch on another bug anyway?
Assignee: nobody → dao
(Assignee)

Comment 3

9 years ago
Created attachment 399571 [details] [diff] [review]
patch
Attachment #399571 - Flags: review?(gavin.sharp)
Attachment #399571 - Flags: review?(gavin.sharp) → review+
(Assignee)

Comment 4

9 years ago
http://hg.mozilla.org/mozilla-central/rev/77a5667b691d
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.7a1
(Assignee)

Comment 5

9 years ago
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/ac9198076b07
status1.9.2: --- → beta1-fixed
just love code bustage/fix/checkin bugs. 

verified per checkin
Keywords: verified1.9.2
You need to log in before you can comment on or make changes to this bug.