Closed Bug 507700 Opened 12 years ago Closed 12 years ago

WARNING: Illegal character in window name calendar-properties-dialog, calendar-gotodate-dialog

Categories

(Calendar :: Dialogs, defect)

defect
Not set
trivial

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: ssitter, Assigned: mschroeder)

Details

Attachments

(1 file, 1 obsolete file)

Shown in debug build when opening dialogs:

WARNING: Illegal character in window name calendar-properties-dialog: file e:/dev/comm-central/src/mozilla/embedding/components/windowwatcher/src/nsWindowWatcher.cpp, line 1420

WARNING: Illegal character in window name calendar-gotodate-dialog: file e:/dev/comm-central/src/mozilla/embedding/components/windowwatcher/src/nsWindowWatcher.cpp, line 1420
Assignee: nobody → mschroeder
Status: NEW → ASSIGNED
OS: Windows XP → All
Hardware: x86 → All
Attached patch Patch v1 (obsolete) — Splinter Review
Attachment #393849 - Flags: review?(ssitter)
Comment on attachment 393849 [details] [diff] [review]
Patch v1

So dashes are not allowed? In that case you should also change the window name in calendar-alarm-dialog.js, calCalendarManager.js (twice, also note openWindow) and gdata-migration.js (uses uri which contains dashes)

r=philipp with that fixed
Attachment #393849 - Flags: review?(ssitter) → review+
Pushed with nits fixed to comm-central <http://hg.mozilla.org/comm-central/rev/385cfd6cf8dd>

-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.0
The attached patch seems to use correct names, the pushed one does not. From a current debug build:

WARNING: Illegal character in window name Calendar:PropertiesDialog
WARNING: Illegal character in window name Calendar:GoToDateDialog
WARNING: Illegal character in window name Calendar:AlarmSnoozePopup
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attached patch Patch v2Splinter Review
":" is forbidden... so changing again!
Attachment #393849 - Attachment is obsolete: true
Attachment #399441 - Flags: review?(ssitter)
Attachment #399441 - Flags: review?(ssitter) → review+
Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/60c2cd3ddeaf>

-> FIXED
Status: REOPENED → RESOLVED
Closed: 12 years ago12 years ago
Resolution: --- → FIXED
verified with
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.9pre) Gecko/20100313 Calendar/1.0b2pre
Status: RESOLVED → VERIFIED
These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".
Target Milestone: 1.0 → 1.0b1
You need to log in before you can comment on or make changes to this bug.