Closed
Bug 507700
Opened 15 years ago
Closed 15 years ago
WARNING: Illegal character in window name calendar-properties-dialog, calendar-gotodate-dialog
Categories
(Calendar :: Dialogs, defect)
Calendar
Dialogs
Tracking
(Not tracked)
VERIFIED
FIXED
1.0b1
People
(Reporter: ssitter, Assigned: mschroeder)
Details
Attachments
(1 file, 1 obsolete file)
5.30 KB,
patch
|
Fallen
:
review+
|
Details | Diff | Splinter Review |
Shown in debug build when opening dialogs: WARNING: Illegal character in window name calendar-properties-dialog: file e:/dev/comm-central/src/mozilla/embedding/components/windowwatcher/src/nsWindowWatcher.cpp, line 1420 WARNING: Illegal character in window name calendar-gotodate-dialog: file e:/dev/comm-central/src/mozilla/embedding/components/windowwatcher/src/nsWindowWatcher.cpp, line 1420
Assignee | ||
Updated•15 years ago
|
Assignee: nobody → mschroeder
Status: NEW → ASSIGNED
OS: Windows XP → All
Hardware: x86 → All
Assignee | ||
Comment 1•15 years ago
|
||
Attachment #393849 -
Flags: review?(ssitter)
Comment 2•15 years ago
|
||
Comment on attachment 393849 [details] [diff] [review] Patch v1 So dashes are not allowed? In that case you should also change the window name in calendar-alarm-dialog.js, calCalendarManager.js (twice, also note openWindow) and gdata-migration.js (uses uri which contains dashes) r=philipp with that fixed
Attachment #393849 -
Flags: review?(ssitter) → review+
Assignee | ||
Comment 3•15 years ago
|
||
Pushed with nits fixed to comm-central <http://hg.mozilla.org/comm-central/rev/385cfd6cf8dd> -> FIXED
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.0
Reporter | ||
Comment 4•15 years ago
|
||
The attached patch seems to use correct names, the pushed one does not. From a current debug build: WARNING: Illegal character in window name Calendar:PropertiesDialog WARNING: Illegal character in window name Calendar:GoToDateDialog WARNING: Illegal character in window name Calendar:AlarmSnoozePopup
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 5•15 years ago
|
||
":" is forbidden... so changing again!
Attachment #393849 -
Attachment is obsolete: true
Attachment #399441 -
Flags: review?(ssitter)
Updated•15 years ago
|
Attachment #399441 -
Flags: review?(ssitter) → review+
Comment 6•15 years ago
|
||
Comment on attachment 399441 [details] [diff] [review] Patch v2 r=philipp
Assignee | ||
Comment 7•15 years ago
|
||
Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/60c2cd3ddeaf> -> FIXED
Status: REOPENED → RESOLVED
Closed: 15 years ago → 15 years ago
Resolution: --- → FIXED
Comment 8•14 years ago
|
||
verified with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.9pre) Gecko/20100313 Calendar/1.0b2pre
Status: RESOLVED → VERIFIED
Comment 9•13 years ago
|
||
These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".
Target Milestone: 1.0 → 1.0b1
You need to log in
before you can comment on or make changes to this bug.
Description
•