507700 - WARNING: Illegal character in window name calendar-properties-dialog, calendar-gotodate-dialog

Status: VERIFIED FIXED

(Calendar :: Dialogs, defect)

Description

[Stefan Sitter [:ssitter]]

Shown in debug build when opening dialogs:

WARNING: Illegal character in window name calendar-properties-dialog: file e:/dev/comm-central/src/mozilla/embedding/components/windowwatcher/src/nsWindowWatcher.cpp, line 1420

WARNING: Illegal character in window name calendar-gotodate-dialog: file e:/dev/comm-central/src/mozilla/embedding/components/windowwatcher/src/nsWindowWatcher.cpp, line 1420

Comment 1

[Martin Schröder [:mschroeder]]

Attachment: Patch v1

Comment 2

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 393849 [details] [diff] [review]
Patch v1

So dashes are not allowed? In that case you should also change the window name in calendar-alarm-dialog.js, calCalendarManager.js (twice, also note openWindow) and gdata-migration.js (uses uri which contains dashes)

r=philipp with that fixed

Comment 3

[Martin Schröder [:mschroeder]]

Pushed with nits fixed to comm-central <http://hg.mozilla.org/comm-central/rev/385cfd6cf8dd>

-> FIXED

Comment 4

[Stefan Sitter [:ssitter]]

The attached patch seems to use correct names, the pushed one does not. From a current debug build:

WARNING: Illegal character in window name Calendar:PropertiesDialog
WARNING: Illegal character in window name Calendar:GoToDateDialog
WARNING: Illegal character in window name Calendar:AlarmSnoozePopup

Comment 5

[Martin Schröder [:mschroeder]]

Attachment: Patch v2

":" is forbidden... so changing again!

Comment 6

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 399441 [details] [diff] [review]
Patch v2

r=philipp

Comment 7

[Martin Schröder [:mschroeder]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/60c2cd3ddeaf>

-> FIXED

Comment 8

[Damian Szczepanik]

verified with
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.9pre) Gecko/20100313 Calendar/1.0b2pre

Comment 9

[Philipp Kewisch [:Fallen][📱📆]]

These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".