507798 - nsMsgComposeSecure.cpp: 2 "warning C4018: '<' : signed/unsigned mismatch"

Status: RESOLVED DUPLICATE of bug 1149320

(MailNews Core :: Security: S/MIME, defect)

Description

[Serge Gautherie (:sgautherie)]

{
.../mailnews/extensions/smime/src/nsMsgComposeSecure.cpp(1032) : warning C4018: '<' : signed/unsigned mismatch
.../mailnews/extensions/smime/src/nsMsgComposeSecure.cpp(1114) : warning C4018: '<' : signed/unsigned mismatch
}
They are "PRUint32 n != PRInt32 size".

It looks like 'size' should be 'PRUint32':
need to check/modify the callers.

Comment 1

[jbonnafo]

Hello,

I would be happy to help on this issue, could you please assign it to me ?

Thanks,

Comment 2

[jbonnafo]

Hello,

i did a build today (release mode with debug info) and i had no warnings at all nsMsgComposeSecure.cpp

My opinion is that the issue is solved.

Can somebody double check ?

Thanks,

Comment 3

[Wayne Mery (:wsmwk)]

aceman might be better able to advise you.

p.s. merywl is my test account

Comment 4

[:aceman]

What compiler on Windows did you use?

Comment 5

[jbonnafo]

Hello,

I have used Microsoft Visual Studio 2015 Community edition.

Thanks,

Comment 6

[:aceman]

The line numbers seem to have changed since the report, but assuming from comment 0 the problems were in comparisions of 'n' variable and 'size' variable. Those have been changed since the report and 'size' is cast to uint32_t .

Incidentally, that was done by me in bug 1149320 :)

Thanks for checking the report and finding it is already solved.