507884 - Remove/fix references to the old nsIPasswordManager in publishprefs.js (Composer)

Status: RESOLVED FIXED

(SeaMonkey :: Composer, defect)

Description

[Frank Wein [:mcsmurf]]

The Composer UI code still tries to use the old password manager, see http://hg.mozilla.org/comm-central/annotate/87e1c230dc9c/editor/ui/composer/content/publishprefs.js#l859, this should be fixed as the code currently can break things like the Publish dialog not automatically closing anymore.

Comment 1

[Frank Wein [:mcsmurf]]

Attachment: Patch

Not sure if this patch is complete yet as the Publish dialog seems to have another bug, too (it does not store the "Site Name" and all settings associated with it?). So this just replaces nsIPasswordManager with nsILoginManager, basically untested.

Comment 2

[Frank Wein [:mcsmurf]]

Attachment: Patch

This one works fine. Need to check if this is what we want because this way we can only support one user/password combination per server as far as I see this.

Comment 3

[Frank Wein [:mcsmurf]]

Comment on attachment 392151 [details] [diff] [review]
Patch

As far as I know you're a peer for this code :)

Comment 4

[timeless]

Comment on attachment 392151 [details] [diff] [review]
Patch

whitespace at the end is wrong :/

Comment 5

[Frank Wein [:mcsmurf]]

Attachment: Patch

Fixes whitespace, now also allows multiple users per server when using ftp by storing ftp://user@host in the password manager.

Comment 6

[Frank Wein [:mcsmurf]]

Pushed to comm-central, http://hg.mozilla.org/comm-central/rev/6bd79b0f2f17