507896 - Upgrading Seamonkey changes file type icon for HTML files to mail

Status: RESOLVED FIXED

(SeaMonkey :: Installer, defect)

Description

[Boris 'pi' Piwinger]

After (automatic) upgrading from alpha to Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1.1pre) Gecko/20090717 SeaMonkey/2.0b1 in Windows Vista all HTML files (including .html, .htm, .shtml) are displayed with the SeaMonkey mail icon (the envelope with the down arrow).

I tried to reassign those file types to IE (which worked showing the IE icon). Then reassigned to SeaMonkey. Again wrong icon.

It was correct before the upgrade.

pi

Comment 1

[Frank Wein [:mcsmurf]]

Do you happen to know the file name of the icon? Or can you post a screen shot of the icon? The only arrow down icon I can remember atm is http://mxr.mozilla.org/comm-central/source/suite/branding/icons/windows/downloadManager.ico

Comment 2

[Boris 'pi' Piwinger]

It is the second icon included in seamonkey.exe. Screenshot follows.

pi

Comment 3

[Boris 'pi' Piwinger]

Attachment: Screenshot of iccon displayed for HTML file type

Comment 4

[Frank Wein [:mcsmurf]]

seamonkey.exe does not include that icon, seamonkey.exe only has one embedded icon, the logo itself (you can check this by creating a shortcut to seamonkey.exe and clicking on "Anderes Symbol..." in the properties of the shortcut).

Comment 5

[Jürgen 'JiHa' Harter]

Maybe there is something wrong with Windows' icon cache. AFAIR XP did have such a cache and this could have caused such troubles.

Actually I'm not on Windows and I hardly know anything about Vista.

Comment 6

[Boris 'pi' Piwinger]

Attachment: Windows Vista Icon Dialog for SeaMonkey

Frank, this is exactly, what I did. I receive three icons to choose from: the SeaMonkey in the blue circle, the envelope and again the first icon.

pi

Comment 7

[Boris 'pi' Piwinger]

Jürgen, good idea. Yet not successful. I deleted the IconCache.db, restarted the system, but nothing changed.

pi

Comment 8

[Frank Wein [:mcsmurf]]

Looks like the icon was added in Bug 389448.
Not sure though why it chooses that one as icon. Can you check in the registry what value HKEY_CLASSES_ROOT\SeaMonkeyHTML\DefaultIcon is set to?

Comment 9

[Boris 'pi' Piwinger]

It is set to "C:\Program Files\SeaMonkey\chrome\icons\default\html-file.ico". That would be correct. Yet this is not what is used.

pi

Comment 10

[Ian Neal]

Yes, this is a regression. Would be useful to try and narrow the regression window.

Comment 11

[Frank Wein [:mcsmurf]]

Attachment: Patch [Checked in: Comment 12]

Should fix this problem, although I'm not really sure. But it certainly fixes a bug in the code that might cause this bug here.

Comment 12

[Frank Wein [:mcsmurf]]

Checked in: http://hg.mozilla.org/comm-central/rev/e7c2a5448c9e

Comment 13

[Boris 'pi' Piwinger]

Upgrading to Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1.4) Gecko/20091007 SeaMonkey/2.0 changes the problem. Now for .html files a white sheet of paper is used as the icon.

pi

Comment 14

[Frank Wein [:mcsmurf]]

Can you check what value HKEY_CLASSES_ROOT\SeaMonkeyHTML\DefaultIcon has in the registry? Can you also check if the key HKEY_LOCAL_MACHINE\Software\Classes\SeaMonkeyHTML\ShellEx\IconHandler exists? If it does exist, please check what value the key HKEY_LOCAL_MACHINE\Software\CLSID\[value of the IconHandler key]\Old Icon\SeaMonkeyHTML\DefaultIcon is set to and post all the values to this bug here.

Comment 15

[Boris 'pi' Piwinger]

Sure.

HKEY_CLASSES_ROOT\SeaMonkeyHTML\DefaultIcon: C:\Program Files\SeaMonkey\chrome\icons\default\html-file.ico (this actually is the icon I would expect)

HKEY_LOCAL_MACHINE\Software\Classes\SeaMonkeyHTML\ShellEx\IconHandler has value {42042206-2D85-11D3-8CFF-005004838597}

HKEY_LOCAL_MACHINE\Software\CLSID does not exist. Did you mean HKEY_LOCAL_MACHINE\SOFTWARE\Classes\CLSID\{42042206-2D85-11D3-8CFF-005004838597}\Old Icon\SeaMonkeyHTML\DefaultIcon? It has value C:\Program Files\SeaMonkey\chrome\icons\default\html-file.ico

HTML files (as shown in Windows Explorer) habe file type SeaMonkey Document, yet show a white sheet of paper logo.

pi

Comment 16

[Robert Kaiser]

This bug is open but targeted for seamonkey2.0b2, which has been released a significant time ago. Please set the target milestone to an appropriate value, "---" if it has no specific target.

Comment 17

[Frank Wein [:mcsmurf]]

Resetting target milestone for now, will try to find the cause of this bug.

Comment 18

[Justin Wood (:Callek)]

mcsmurf, Boris

Have either of you spent any additional time on this; is it still a problem? Initial Patch has landed, however no recent progress. We are nearing beta for 2.1 and it would be useful to get this accomplished for at least that release if it is still an issue.

...in-fact since this was a blocking+ bug from a while ago, and landed for 2.0b2, I'm resolving fixed and setting the t-m correctly. NEW BUG PLEASE if this is still an issue, so we can triage/track it correctly.

Comment 19

[Frank Wein [:mcsmurf]]

I tried to find what is causing this bug, but then I was unable to reproduce the bug :( iirc third party software was involved..

Comment 20

[Boris 'pi' Piwinger]

I still have the issue. No third party I am aware of involved.

Comment 21

[Serge Gautherie (:sgautherie)]

(In reply to Justin Wood (:Callek) from comment #18)
> NEW BUG PLEASE if
> this is still an issue, so we can triage/track it correctly.

Bug 716234.

(In reply to Frank Wein [:mcsmurf] from comment #19)
> I tried to find what is causing this bug, but then I was unable to reproduce
> the bug :( iirc third party software was involved..

Please, don't reopen this bug.