Closed Bug 507930 Opened 12 years ago Closed 12 years ago

Workers: Implement WorkerLocation

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: bent.mozilla, Assigned: bent.mozilla)

References

Details

Attachments

(1 file)

This was added to the spec and we should get it in.
Attached patch Patch, v1Splinter Review
Assignee: nobody → bent.mozilla
Status: NEW → ASSIGNED
Attachment #392325 - Flags: superreview?(jst)
Attachment #392325 - Flags: review?(jst)
Comment on attachment 392325 [details] [diff] [review]
Patch, v1

+interface nsIWorkerLocation : nsISupports
+{
+  readonly attribute DOMString href;
...

Since the objects that implement this interface are created eagerly per worker, and since the code that does that need to convert from UTF8 to UTF16, you could change this interface to use AUTF8String instead of DOMString and save a bit of memory and push the cost of conversion to the users of this (of which there will be pretty few I'd argue).

r+sr=jst either way.
Attachment #392325 - Flags: superreview?(jst)
Attachment #392325 - Flags: superreview+
Attachment #392325 - Flags: review?(jst)
Attachment #392325 - Flags: review+
Pushed changeset b9cee22bad2e to mozilla-central.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.