Closed
Bug 507930
Opened 16 years ago
Closed 16 years ago
Workers: Implement WorkerLocation
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
People
(Reporter: bent.mozilla, Assigned: bent.mozilla)
References
Details
Attachments
(1 file)
|
19.43 KB,
patch
|
jst
:
review+
jst
:
superreview+
|
Details | Diff | Splinter Review |
This was added to the spec and we should get it in.
|
Assignee | |
Comment 1•16 years ago
|
||
|
|
Assignee | |
Comment 2•16 years ago
|
||
Assignee: nobody → bent.mozilla
Status: NEW → ASSIGNED
Attachment #392325 -
Flags: superreview?(jst)
Attachment #392325 -
Flags: review?(jst)
|
||
Comment 3•16 years ago
|
||
Comment on attachment 392325 [details] [diff] [review]
Patch, v1
+interface nsIWorkerLocation : nsISupports
+{
+ readonly attribute DOMString href;
...
Since the objects that implement this interface are created eagerly per worker, and since the code that does that need to convert from UTF8 to UTF16, you could change this interface to use AUTF8String instead of DOMString and save a bit of memory and push the cost of conversion to the users of this (of which there will be pretty few I'd argue).
r+sr=jst either way.
Attachment #392325 -
Flags: superreview?(jst)
Attachment #392325 -
Flags: superreview+
Attachment #392325 -
Flags: review?(jst)
Attachment #392325 -
Flags: review+
|
|
Assignee | |
Comment 4•16 years ago
|
||
Pushed changeset b9cee22bad2e to mozilla-central.
|
|
Assignee | |
Updated•16 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•