Closed Bug 507945 Opened 10 years ago Closed 10 years ago

Web content can change the gradient in the titlebar, draw rect position check in DrawUnifiedToolbar doesn't work

Categories

(Core :: Widget: Cocoa, defect)

All
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla1.9.2a1

People

(Reporter: mstange, Assigned: mstange)

References

Details

Attachments

(2 files)

Attached file testcase
No description provided.
Attached patch v1Splinter Review
The levelsUp check has never worked since aFrame->GetWindow() apparently always returns the top level widget... and it won't work in the future when there's only one widget.
The check for the draw rect's position isn't enough because it doesn't take into consideration that there might be a translation transform on the context. This patch fixes that.
Attachment #392190 - Flags: superreview?(roc)
Attachment #392190 - Flags: review?(joshmoz)
Attachment #392190 - Flags: superreview?(roc) → superreview+
Attachment #392190 - Flags: review?(joshmoz) → review+
http://hg.mozilla.org/mozilla-central/rev/a285b8d3c18e
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
You need to log in before you can comment on or make changes to this bug.