507981 - respect gtk-alternative-button-order GtkSetting for the filechooser

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Wolfgang Rosenauer [:wolfiR]]

Downstream reference:
https://bugzilla.novell.com/show_bug.cgi?id=527418

The integrated Gtk filechooser doesn't respect the gtk-alternative-button-order property.
AFAIK in Xul dialogs the button order is hardcoded so it's not clear what the preferred behaviour is but for example the printing dialogs are not implemented in mozilla at all and respect the setting so there is already a UI consistency breakage.
I'll add a patch but propose a decision from UI people.

Comment 1

[Wolfgang Rosenauer [:wolfiR]]

Attachment: patch (1.9.1)

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 392220 [details] [diff] [review]
patch (1.9.1)

I think this is good.

Comment 3

[Wolfgang Rosenauer [:wolfiR]]

Attachment: patch (mozilla-central)

Comment 4

[Wolfgang Rosenauer [:wolfiR]]

Comment on attachment 396419 [details] [diff] [review]
patch (mozilla-central)

attached the branch version by accident, sorry. Here is the mozilla-central version for which I didn't want to just forward the r+

Comment 5

[Wolfgang Rosenauer [:wolfiR]]

http://hg.mozilla.org/mozilla-central/rev/75545d6400ef

Comment 6

[Wolfgang Rosenauer [:wolfiR]]

Asking wanted-1.9.2 as I'm wondering why that doesn't get approved or denied since weeks.

Comment 7

[Wolfgang Rosenauer [:wolfiR]]

1.9.2:
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/dbf77c4cb29b