Closed Bug 508156 Opened 11 years ago Closed 11 years ago

configure.in: remove AC_DEFINE(_WIN32)

Categories

(Firefox Build System :: General, defect, trivial)

x86
Windows 2000
defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9.2b1

People

(Reporter: sgautherie, Assigned: sgautherie)

References

()

Details

Attachments

(2 files)

Bug 433790 comment 21:
{
From  Wan-Teh Chang   2009-08-03 16:18:44 PDT

(In reply to comment #19)
>
> http://mxr.mozilla.org/mozilla-central/search?string=AC_DEFINE%28_WIN32%29&case=on&find=%2Fconfigure%5C.in%24
> /configure.in
>     * line 2088 -- AC_DEFINE(_WIN32)    // *-wince*)
>     * line 2207 -- AC_DEFINE(_WIN32)    // *-mingw*|*-cygwin*|*-msvc*|*-mks*)

You may want to remove these AC_DEFINE's because _WIN32 is implicitly
defined by the compiler.
}
Fwiw,
http://predef.sourceforge.net/preos.html#sec24
{
MS Windows
Type 	Macro 	Description
Identification 	_WIN32 	Defined for both 32-bit and 64-bit environments
}
Assignee: nobody → sgautherie.bz
Status: NEW → ASSIGNED
Attachment #392468 - Flags: review?(ted.mielczarek)
Attachment #392468 - Flags: review?(ted.mielczarek) → review+
Comment on attachment 392468 [details] [diff] [review]
(Av1) Just remove it
[Checkin: Comment 3]


http://hg.mozilla.org/mozilla-central/rev/4e16b4e3932b
Attachment #392468 - Attachment description: (Av1) Just remove it → (Av1) Just remove it [Checkin: Comment 3]
Blocks: C192ConfSync
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2b1
It looks like I missed it at the time :-<
Attachment #423349 - Flags: review?(bugspam.Callek)
(In reply to comment #4)
> It looks like I missed it at the time :-<

Ah, I waited for c-1.9.1 to branch.!.
Attachment #423349 - Flags: review?(bugspam.Callek) → review+
Comment on attachment 423349 [details] [diff] [review]
(Bv1-CC) Just remove it
[Checkin: Comment 6]


http://hg.mozilla.org/comm-central/rev/b70bb816ee9a
Attachment #423349 - Attachment description: (Bv1-CC) Just remove it → (Bv1-CC) Just remove it [Checkin: Comment 6]
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.