Closed Bug 508180 Opened 12 years ago Closed 12 years ago

Consolidate four nsXULWindow::Load*FormXUL methods

Categories

(Core :: XUL, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9.2a1

People

(Reporter: mstange, Assigned: mstange)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch v1 (obsolete) — Splinter Review
This patch is on top of the one in bug 269410. I'm also making the hidechrome attribute case-sensitive.
Attachment #392412 - Flags: review?(neil)
Comment on attachment 392412 [details] [diff] [review]
v1

>+   NS_IMETHOD SyncAttributesToWidget();
This should probably just be void rather than NS_IMETHOD.
Attached patch v2Splinter Review
You're right, and I have no idea how this could even compile.
Attachment #392412 - Attachment is obsolete: true
Attachment #392667 - Flags: review?(neil)
Attachment #392412 - Flags: review?(neil)
Attachment #392667 - Flags: review?(neil) → review+
http://hg.mozilla.org/mozilla-central/rev/35d52ec7e884
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
Moving to Core:XUL per https://bugzilla.mozilla.org/show_bug.cgi?id=1455336
Component: XP Toolkit/Widgets: XUL → XUL
You need to log in before you can comment on or make changes to this bug.