508186 - Speed up UTF-8 table conversion in checksetup

Status: RESOLVED FIXED

(Bugzilla :: Installation & Upgrading, enhancement)

Description

[Max Kanat-Alexander]

Right now we issue two ALTER TABLE commands for every column that we're updating. Instead, we should just issue two ALTER TABLE commands for the whole table, when doing the UTF-8 conversion.

Comment 1

[Max Kanat-Alexander]

Attachment: v1

Tested, works in all the various upgrading situations. (Note that we no longer need special code for the old fulltext indexes because the InnoDB upgrade process already handles that.)

Comment 2

[Max Kanat-Alexander]

Holding approval until blocker is ready.

Note that I need to fix the grammar when I check this in: "to UTF-8" in the message.

Comment 3

[Max Kanat-Alexander]

Checking in Bugzilla/DB/Mysql.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/DB/Mysql.pm,v  <--  Mysql.pm
new revision: 1.75; previous revision: 1.74
done

Comment 4

[Max Kanat-Alexander]

Apparently I sped it up so much that it doesn't work at all anymore. (Tables are changed to utf8, but columns stay latin1, for some reason.)

Comment 5

[Max Kanat-Alexander]

Attachment: Fix

Okay, this fixes it. Granting myself review as module owner.

Comment 6

[Max Kanat-Alexander]

Checking in Bugzilla/DB/Mysql.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/DB/Mysql.pm,v  <--  Mysql.pm
new revision: 1.76; previous revision: 1.75
done

Comment 7

[Max Kanat-Alexander]

Oh, and the new patch also included another optimization--we throw the DEFAULT CHARACTER SET change in with the column changes, if there are column changes.